commit 38d909ec2875f79952de08f36adfaac5680d2c53
author bungeman <bungeman@google.com> Tue Aug 02 14:40:46 2016 -0700
committer Commit bot <commit-bot@chromium.org> Tue Aug 02 14:40:46 2016 -0700
tree a11067146b42f3faa8531d6ef912f7246bbde1f2
parent ada5a44f3bdac10a8a0c53b34f5add7aea9fdbb0

Move off SK_SUPPORT_LEGACY_DATA_FACTORIES.

This moves Skia code off of SK_SUPPORT_LEGACY_DATA_FACTORIES.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2206633004

Review-Url: https://codereview.chromium.org/2206633004

tools/lua/lua_app.cpp

diff --git a/tools/lua/lua_app.cpp b/tools/lua/lua_app.cpp
index 6aea8ee..92623d0 100644
--- a/tools/lua/lua_app.cpp
+++ b/tools/lua/lua_app.cpp
@@ -19,10 +19,10 @@
     #include "lauxlib.h"
 }
 
-static SkData* read_into_data(const char file[]) {
-    SkData* data = SkData::NewFromFileName(file);
+static sk_sp<SkData> read_into_data(const char file[]) {
+    sk_sp<SkData> data(SkData::MakeFromFileName(file));
     if (!data) {
-        data = SkData::NewEmpty();
+        data = SkData::MakeEmpty();
     }
     return data;
 }
@@ -33,7 +33,7 @@
     SkLua L;
 
     for (int i = 1; i < argc; ++i) {
-        SkData* data = nullptr;
+        sk_sp<SkData> data;
         const void* ptr;
         size_t len;
 
@@ -50,7 +50,6 @@
             SkDebugf("failed to load %s\n", argv[i]);
             exit(-1);
         }
-        SkSafeUnref(data);
     }
     return 0;
 }

tools/lua/lua_pictures.cpp

diff --git a/tools/lua/lua_pictures.cpp b/tools/lua/lua_pictures.cpp
index 9776002..eee7088 100644
--- a/tools/lua/lua_pictures.cpp
+++ b/tools/lua/lua_pictures.cpp
@@ -85,9 +85,9 @@
     SkLua L(summary);
 
     for (int i = 0; i < FLAGS_luaFile.count(); ++i) {
-        SkAutoDataUnref data(SkData::NewFromFileName(FLAGS_luaFile[i]));
-        if (nullptr == data.get()) {
-            data.reset(SkData::NewEmpty());
+        sk_sp<SkData> data(SkData::MakeFromFileName(FLAGS_luaFile[i]));
+        if (!data) {
+            data = SkData::MakeEmpty();
         }
         if (!FLAGS_quiet) {
             SkDebugf("loading %s...\n", FLAGS_luaFile[i]);