Remove overly complicated GR_CREATE_STATIC_PROCESSOR macro
This macro was responsible for producing code like:
static SkAlignedStorage<sizeof(Foo)> g_gFoo_Storage;
static Foo* gFoo = new(g_gFoo_Storage.get()) Foo;
static SkAutoTDestroy<Foo> gFoo_ad(gFoo);
which would allocate static storage for an object of type Foo
(g_gFoo_Storage), lazily instantiate the object in that memory (via
gFoo's initializer), and then ensure that at global destruction time
the object is destroyed (via gFoo_Ad's destructor).
However, the exact same effect is achieved by just writing:
static Foo gFoo;
Review URL: https://codereview.chromium.org/1314763009
diff --git a/tests/GLProgramsTest.cpp b/tests/GLProgramsTest.cpp
index 7bf5f24..ffddd1f 100644
--- a/tests/GLProgramsTest.cpp
+++ b/tests/GLProgramsTest.cpp
@@ -62,8 +62,8 @@
class BigKeyProcessor : public GrFragmentProcessor {
public:
static GrFragmentProcessor* Create() {
- GR_CREATE_STATIC_PROCESSOR(gBigKeyProcessor, BigKeyProcessor, ())
- return SkRef(gBigKeyProcessor);
+ static BigKeyProcessor gBigKeyProcessor;
+ return SkRef(&gBigKeyProcessor);
}
const char* name() const override { return "Big Ole Key"; }