commit 391a9f64cb956cc4cd841cc3b795f25e51f36a5c
author John Stiles <johnstiles@google.com> Thu Apr 29 23:17:41 2021 -0400
committer Skia Commit-Bot <skia-commit-bot@chromium.org> Fri Apr 30 18:31:19 2021 +0000
tree 54a77915a152ca207657c3e2f12b531540f6e1e9
parent 768d97133da9dcd00bf2e461565502eaf08f2ba0

Fetch random numbers for TestCreate in a predictable order.

We want our randomized tests to behave predictably when given a fixed
seed, but C++ is allowed to arbitrarily reorder our calls to
random->nextXxxx() when we call it more than once on the same line.
Each random-fetching call is now performed separately.

Change-Id: I8d9c0fcd7e5c931d3a963a2e401ea8b66535fc4f
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/402716
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: John Stiles <johnstiles@google.com>

src/gpu/gradients/generated/GrLinearGradientLayout.cpp

diff --git a/src/gpu/gradients/generated/GrLinearGradientLayout.cpp b/src/gpu/gradients/generated/GrLinearGradientLayout.cpp
index 98e576f..92106d2 100644
--- a/src/gpu/gradients/generated/GrLinearGradientLayout.cpp
+++ b/src/gpu/gradients/generated/GrLinearGradientLayout.cpp
@@ -59,9 +59,11 @@
 #if GR_TEST_UTILS
 std::unique_ptr<GrFragmentProcessor> GrLinearGradientLayout::TestCreate(GrProcessorTestData* d) {
     SkScalar scale = GrGradientShader::RandomParams::kGradientScale;
-    SkPoint points[] = {
-            {d->fRandom->nextRangeScalar(0.0f, scale), d->fRandom->nextRangeScalar(0.0f, scale)},
-            {d->fRandom->nextRangeScalar(0.0f, scale), d->fRandom->nextRangeScalar(0.0f, scale)}};
+    SkPoint points[2];
+    points[0].fX = d->fRandom->nextRangeScalar(0.0f, scale);
+    points[0].fY = d->fRandom->nextRangeScalar(0.0f, scale);
+    points[1].fX = d->fRandom->nextRangeScalar(0.0f, scale);
+    points[1].fY = d->fRandom->nextRangeScalar(0.0f, scale);
 
     GrGradientShader::RandomParams params(d->fRandom);
     auto shader = params.fUseColors4f ? SkGradientShader::MakeLinear(points,