DM: Push GPU-parent child tasks to the front of the queue.
Like yesterday's change to run CPU-parent child tasks serially in thread, this
reduces peak memory usage by improving the temporaly locality of the bitmaps we
create.
E.g. Let's say we start with tasks A B C and D
Queue: [ A B C D ]
Running A creates A' and A", which depend on a bitmap created by A.
Queue: [ B C D A' A" * ]
That bitmap now needs sit around in RAM while B C and D run pointlessly and can
only be destroyed at *. If instead we do this and push dependent child tasks
to the front of the queue, the queue and bitmap lifetime looks like this:
Queue: [ A' A" * B C D ]
This is much, much worse in practice because the queue is often several thousand
tasks long. 100s of megs of bitmaps can pile up for 10s of seconds pointlessly.
To make this work we add addNext() to SkThreadPool and its cousin DMTaskRunner.
I also took the opportunity to swap head and tail in the threadpool
implementation so it matches the comments and intuition better: we always pop
the head, add() puts it at the tail, addNext() at the head.
Before
Debug: 49s, 1403352k peak
Release: 16s, 2064008k peak
After
Debug: 49s, 1234788k peak
Release: 15s, 1903424k peak
BUG=skia:2478
R=bsalomon@google.com, borenet@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/263803003
git-svn-id: http://skia.googlecode.com/svn/trunk@14506 2bbb7eff-a529-9590-31e7-b0007b416f81
diff --git a/dm/DMTask.cpp b/dm/DMTask.cpp
index 83df849..7725780 100644
--- a/dm/DMTask.cpp
+++ b/dm/DMTask.cpp
@@ -37,8 +37,8 @@
fReporter->finish(this->name(), SkTime::GetMSecs() - fStart);
}
-void Task::reallySpawnChild(CpuTask* task) {
- fTaskRunner->add(task);
+void Task::spawnChildNext(CpuTask* task) {
+ fTaskRunner->addNext(task);
}
CpuTask::CpuTask(Reporter* reporter, TaskRunner* taskRunner) : Task(reporter, taskRunner) {}
@@ -55,6 +55,8 @@
void CpuTask::spawnChild(CpuTask* task) {
// Run children serially on this (CPU) thread. This tends to save RAM and is usually no slower.
+ // Calling spawnChildNext() is nearly equivalent, but it'd pointlessly contend on the
+ // threadpool; spawnChildNext() is most useful when you want to change threadpools.
task->run();
}
@@ -71,7 +73,8 @@
void GpuTask::spawnChild(CpuTask* task) {
// Really spawn a new task so it runs on the CPU threadpool instead of the GPU one we're on now.
- this->reallySpawnChild(task);
+ // It goes on the front of the queue to minimize the time we must hold reference bitmaps in RAM.
+ this->spawnChildNext(task);
}
} // namespace DM