commit 3fe0327585f32ea2b9334965d8c90d9d699c584e
author egdaniel <egdaniel@google.com> Mon Aug 15 10:59:17 2016 -0700
committer Commit bot <commit-bot@chromium.org> Mon Aug 15 10:59:17 2016 -0700
tree 1ad39062e770bda683d1882421157c2163cee000
parent ea246cd5fb43e2b4aaeccc76d05a8a89735671c2

Fix 4444 on Vulkan devices who don't support RGBA_4444

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2238563002

Committed: https://skia.googlesource.com/skia/+/637b3bf2b9c10398d823bd015a722842d4f2f971
Review-Url: https://codereview.chromium.org/2238563002

src/gpu/GrGpu.cpp

diff --git a/src/gpu/GrGpu.cpp b/src/gpu/GrGpu.cpp
index 7199b4d..e14e892 100644
--- a/src/gpu/GrGpu.cpp
+++ b/src/gpu/GrGpu.cpp
@@ -277,6 +277,12 @@
         return false;
     }
 
+    // We currently do not support reading into the packed formats 565 or 4444 as they are not
+    // required to have read back support on all devices and backends.
+    if (kRGB_565_GrPixelConfig == readConfig || kRGBA_4444_GrPixelConfig == readConfig) {
+        return false;
+    }
+
     if (!this->onGetReadPixelsInfo(srcSurface, width, height, rowBytes, readConfig, drawPreference,
                                    tempDrawInfo)) {
         return false;

src/gpu/vk/GrVkCaps.cpp

diff --git a/src/gpu/vk/GrVkCaps.cpp b/src/gpu/vk/GrVkCaps.cpp
index cf9f4f0..9027f68 100644
--- a/src/gpu/vk/GrVkCaps.cpp
+++ b/src/gpu/vk/GrVkCaps.cpp
@@ -137,7 +137,16 @@
             glslCaps->fConfigTextureSwizzle[i] = GrSwizzle::RRRR();
             glslCaps->fConfigOutputSwizzle[i] = GrSwizzle::AAAA();
         } else {
-            glslCaps->fConfigTextureSwizzle[i] = GrSwizzle::RGBA();
+            if (kRGBA_4444_GrPixelConfig == config) {
+                // The vulkan spec does not require R4G4B4A4 to be supported for texturing so we
+                // store the data in a B4G4R4A4 texture and then swizzle it when doing texture reads
+                // or writing to outputs. Since we're not actually changing the data at all, the
+                // only extra work is the swizzle in the shader for all operations.
+                glslCaps->fConfigTextureSwizzle[i] = GrSwizzle::BGRA();
+                glslCaps->fConfigOutputSwizzle[i] = GrSwizzle::BGRA();
+            } else {
+                glslCaps->fConfigTextureSwizzle[i] = GrSwizzle::RGBA();
+            }
         }
     }
 

src/gpu/vk/GrVkCaps.h

diff --git a/src/gpu/vk/GrVkCaps.h b/src/gpu/vk/GrVkCaps.h
index ca92e59..3733f2c 100644
--- a/src/gpu/vk/GrVkCaps.h
+++ b/src/gpu/vk/GrVkCaps.h
@@ -101,7 +101,7 @@
         uint16_t fLinearFlags;
     };
     ConfigInfo fConfigTable[kGrPixelConfigCnt];
-    
+
     StencilFormat fPreferedStencilFormat;
 
     // Tells of if we can pass in straight GLSL string into vkCreateShaderModule

src/gpu/vk/GrVkUtil.cpp

diff --git a/src/gpu/vk/GrVkUtil.cpp b/src/gpu/vk/GrVkUtil.cpp
index 760b20b..ffbad25 100644
--- a/src/gpu/vk/GrVkUtil.cpp
+++ b/src/gpu/vk/GrVkUtil.cpp
@@ -30,7 +30,9 @@
             *format = VK_FORMAT_R5G6B5_UNORM_PACK16;
             break;
         case kRGBA_4444_GrPixelConfig:
-            *format = VK_FORMAT_R4G4B4A4_UNORM_PACK16;
+            // R4G4B4A4 is not required to be supported so we actually
+            // store the data is if it was B4G4R4A4 and swizzle in shaders
+            *format = VK_FORMAT_B4G4R4A4_UNORM_PACK16;
             break;
         case kIndex_8_GrPixelConfig:
             // No current vulkan support for this config
@@ -88,7 +90,9 @@
         case VK_FORMAT_R5G6B5_UNORM_PACK16:
             *config = kRGB_565_GrPixelConfig;
             break;
-        case VK_FORMAT_R4G4B4A4_UNORM_PACK16:
+        case VK_FORMAT_B4G4R4A4_UNORM_PACK16:
+            // R4G4B4A4 is not required to be supported so we actually
+            // store RGBA_4444 data as B4G4R4A4.
             *config = kRGBA_4444_GrPixelConfig;
             break;
         case VK_FORMAT_R8_UNORM: