create ops directly for drawGlyphs, etc.
If there is no SkTextBlob associated with the glyphRunList,
then there is no possibility for reuse. Don't create a
GrTextBlob, and don't consult the cache. Just build the
GrAtlasTextOp directly.
Change-Id: I2dbdb2a01ef62c1bdaa1010796b4d58a9b455640
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/399896
Commit-Queue: Herb Derby <herb@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>
diff --git a/src/gpu/GrSurfaceDrawContext.cpp b/src/gpu/GrSurfaceDrawContext.cpp
index 6a317dc..3363976 100644
--- a/src/gpu/GrSurfaceDrawContext.cpp
+++ b/src/gpu/GrSurfaceDrawContext.cpp
@@ -415,8 +415,10 @@
return;
}
- if (gGrDrawTextNoCache) {
- // drawGlyphRunListNoCache lives in GrTextBlob.cpp to share sub run implementation code.
+ if (gGrDrawTextNoCache || glyphRunList.blob() == nullptr) {
+ // If the glyphRunList does not have an associated text blob, then it was created by one of
+ // the direct draw APIs (drawGlyphs, etc.). There is no need to create a GrTextBlob just
+ // build the sub run directly and place it in the op.
this->drawGlyphRunListNoCache(clip, viewMatrix, glyphRunList, paint);
} else {
this->drawGlyphRunListWithCache(clip, viewMatrix, glyphRunList, paint);