Remove PLS path renderer
Change-Id: Ib727b0749a5a7da95832970e79804417e8b6a247
Reviewed-on: https://skia-review.googlesource.com/9300
Reviewed-by: Ethan Nicholas <ethannicholas@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
diff --git a/src/gpu/effects/GrCustomXfermode.cpp b/src/gpu/effects/GrCustomXfermode.cpp
index ccbab73..8895d7c 100644
--- a/src/gpu/effects/GrCustomXfermode.cpp
+++ b/src/gpu/effects/GrCustomXfermode.cpp
@@ -52,16 +52,11 @@
#undef EQ_OFFSET
}
-static bool can_use_hw_blend_equation(GrBlendEquation equation,
- bool usePLSRead,
- bool isLCDCoverage,
+static bool can_use_hw_blend_equation(GrBlendEquation equation, bool isLCDCoverage,
const GrCaps& caps) {
if (!caps.advancedBlendEquationSupport()) {
return false;
}
- if (usePLSRead) {
- return false;
- }
if (isLCDCoverage) {
return false; // LCD coverage must be applied after the blend equation.
}
@@ -334,7 +329,7 @@
bool willReadsDst(const FragmentProcessorAnalysis&) const override { return true; }
- bool onWillReadDstInShader(const GrCaps&, const FragmentProcessorAnalysis&) const override;
+ bool willReadDstInShader(const GrCaps&, const FragmentProcessorAnalysis&) const override;
GR_DECLARE_XP_FACTORY_TEST;
@@ -352,20 +347,16 @@
bool hasMixedSamples,
const DstTexture* dstTexture) const {
SkASSERT(GrCustomXfermode::IsSupportedMode(fMode));
- if (can_use_hw_blend_equation(fHWBlendEquation, analysis.usesPLSDstRead(),
- analysis.hasLCDCoverage(), caps)) {
+ if (can_use_hw_blend_equation(fHWBlendEquation, analysis.hasLCDCoverage(), caps)) {
SkASSERT(!dstTexture || !dstTexture->texture());
return new CustomXP(fMode, fHWBlendEquation);
}
return new CustomXP(dstTexture, hasMixedSamples, fMode);
}
-bool CustomXPFactory::onWillReadDstInShader(const GrCaps& caps,
- const FragmentProcessorAnalysis& analysis) const {
- // This should not be called if we're using PLS dst read.
- static constexpr bool kUsesPLSRead = false;
- return !can_use_hw_blend_equation(fHWBlendEquation, kUsesPLSRead, analysis.hasLCDCoverage(),
- caps);
+bool CustomXPFactory::willReadDstInShader(const GrCaps& caps,
+ const FragmentProcessorAnalysis& analysis) const {
+ return !can_use_hw_blend_equation(fHWBlendEquation, analysis.hasLCDCoverage(), caps);
}
GR_DEFINE_XP_FACTORY_TEST(CustomXPFactory);