| commit | 4325270445bf74dda9dbaa9bf05847c8b377495d | [log] [tgz] |
|---|---|---|
| author | Michael Ludwig <michaelludwig@google.com> | Thu May 16 15:04:36 2019 -0400 |
| committer | Skia Commit-Bot <skia-commit-bot@chromium.org> | Fri May 17 14:19:12 2019 +0000 |
| tree | 8fc4a87f2f45468f72e4b795b3f1c8d1834131ec | |
| parent | e5b3e400b6e960814e55cd0e737dce14cb5c199a [diff] |
Remove rounding on explicit clip geometry The rounding that was introduced as part of https://skia-review.googlesource.com/c/skia/+/213132 creates more problems than it is worth, leading to inconsistencies between the CPU and GPU rounding during non-AA rasterization. This removes the rounding so that solid-color axis-aligned draws and clipped draws are always consistent. This reduces the likelihood of running into the issues seen in 423834 (although follow-up changes are needed to apply this same clip consolidation to all SkPaints and texture draws). It does re-expose the background-clip: content-box issue is 957946, but this should be addressed in Blink instead (see https://cs.chromium.org/chromium/src/third_party/blink/renderer/core/paint/box_painter_base.cc?rcl=6269d3758afa9216aa560a0406851a4e628f5a11&l=818) Bug: chromium:957946, chromium:423834 Change-Id: I64540c7d9ceaf46e410ac16c5cdccc6c4bad0089 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/214189 Auto-Submit: Michael Ludwig <michaelludwig@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com>