Remove SkScalarSinCos
This differed from the separate versions in that it snapped to zero.
It was also strictly worse than calling the two separate versions.
Most clients don't need the snapping, so just call the two existing
functions. For clients that need the snapping, call new variants of
each that do snap.
Change-Id: Ia4e09fd9651932fe15caeab1399df7f6281bdc17
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/205303
Commit-Queue: Brian Osman <brianosman@google.com>
Reviewed-by: Mike Reed <reed@google.com>
diff --git a/samplecode/SampleVertices.cpp b/samplecode/SampleVertices.cpp
index 15f2d31..2b86334 100644
--- a/samplecode/SampleVertices.cpp
+++ b/samplecode/SampleVertices.cpp
@@ -158,8 +158,9 @@
v[0].set(0, 0);
t[0].set(0, 0);
for (int i = 0; i < n; i++) {
- SkScalar cos;
- SkScalar sin = SkScalarSinCos(SK_ScalarPI * 2 * i / n, &cos);
+ SkScalar r = SK_ScalarPI * 2 * i / n,
+ sin = SkScalarSin(r),
+ cos = SkScalarCos(r);
v[i+1].set(cos, sin);
t[i+1].set(i*tx/n, ty);
}
@@ -186,8 +187,9 @@
SkPoint* t = rec->fTexs;
for (int i = 0; i < n; i++) {
- SkScalar cos;
- SkScalar sin = SkScalarSinCos(SK_ScalarPI * 2 * i / n, &cos);
+ SkScalar r = SK_ScalarPI * 2 * i / n,
+ sin = SkScalarSin(r),
+ cos = SkScalarCos(r);
v[i*2 + 0].set(cos/2, sin/2);
v[i*2 + 1].set(cos, sin);