commit 49e5b3a339ed18e7bdd7ff8dd4e852d51f051775
author Adlai Holler <adlai@google.com> Mon Feb 08 12:42:49 2021 -0500
committer Skia Commit-Bot <skia-commit-bot@chromium.org> Mon Feb 08 19:22:52 2021 +0000
tree 2f0f794af8caa73ecf8f1bf069cbfc7c37f7a02e
parent a6a3d05ffbac535f7c26410e934b3065507b082e

SW mask gen: release scratch bitmap after upload

This fixes a regression introduced in 366716, where we
were retaining the scratch bitmap. Before that change we were
destroying it after upload which is what we should do.

Bug: skia:11288
Change-Id: Ib567be037a2ff7595cd305a2ef3502d336795c46
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/367880
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Adlai Holler <adlai@google.com>

src/gpu/GrSWMaskHelper.cpp

diff --git a/src/gpu/GrSWMaskHelper.cpp b/src/gpu/GrSWMaskHelper.cpp
index 69c254f..0914876 100644
--- a/src/gpu/GrSWMaskHelper.cpp
+++ b/src/gpu/GrSWMaskHelper.cpp
@@ -92,10 +92,7 @@
                                                        desc.fFit,
                                                        desc.fProtected,
                                                        mip);
-        GrProxyProvider::LazyCallbackResult result(std::move(tex));
-        // Callback refs us, we own bitmap, don't release callback.
-        result.fReleaseCallback = false;
-        return result;
+        return GrProxyProvider::LazyCallbackResult(std::move(tex));
     };
     const GrCaps* caps = context->priv().caps();
     GrProxyProvider* proxyProvider = context->priv().proxyProvider();