commit 4b6f54aaa5da88d0d156f08780200f112faebafa
author Jim Van Verth <jvanverth@google.com> Fri Dec 11 11:01:10 2020 -0500
committer Skia Commit-Bot <skia-commit-bot@chromium.org> Fri Dec 11 19:52:00 2020 +0000
tree 9f5103fcd6281abfa33bf8a463a234c6a74d35cf
parent 8c56f3494aa29a7fa34768242396d4ed9d0c6bfb

Increase QuadEdge precision on all platforms

Bug: skia:10594

Change-Id: I853f05f12c0a3b8e25948c51c11fa9bd01cc67f6
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/343422
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Jim Van Verth <jvanverth@google.com>

src/gpu/ops/GrAAConvexPathRenderer.cpp

diff --git a/src/gpu/ops/GrAAConvexPathRenderer.cpp b/src/gpu/ops/GrAAConvexPathRenderer.cpp
index 3a893cc..c165e06 100644
--- a/src/gpu/ops/GrAAConvexPathRenderer.cpp
+++ b/src/gpu/ops/GrAAConvexPathRenderer.cpp
@@ -568,12 +568,9 @@
             // emit attributes
             varyingHandler->emitAttributes(qe);
 
-#if defined(SK_BUILD_FOR_IOS)
             // GL on iOS 14 needs more precision for the quadedge attributes
+            // We might as well enable it everywhere
             GrGLSLVarying v(kFloat4_GrSLType);
-#else
-            GrGLSLVarying v(kHalf4_GrSLType);
-#endif
             varyingHandler->addVarying("QuadEdge", &v);
             vertBuilder->codeAppendf("%s = %s;", v.vsOut(), qe.fInQuadEdge.name());
 
@@ -650,12 +647,8 @@
             , fUsesLocalCoords(usesLocalCoords) {
         fInPosition = {"inPosition", kFloat2_GrVertexAttribType, kFloat2_GrSLType};
         fInColor = MakeColorAttribute("inColor", wideColor);
-#if defined(SK_BUILD_FOR_IOS)
         // GL on iOS 14 needs more precision for the quadedge attributes
         fInQuadEdge = {"inQuadEdge", kFloat4_GrVertexAttribType, kFloat4_GrSLType};
-#else
-        fInQuadEdge = {"inQuadEdge", kFloat4_GrVertexAttribType, kHalf4_GrSLType};
-#endif
         this->setVertexAttributes(&fInPosition, 3);
     }