commit 4d41b8f2fdae21a6ed16fca6242d53e7c08349d0
author Florin Malita <fmalita@chromium.org> Wed Jul 12 14:35:46 2017 -0400
committer Skia Commit-Bot <skia-commit-bot@chromium.org> Thu Jul 13 02:31:32 2017 +0000
tree bce11f83330bca901f5ca7f699040c7b63293f21
parent 1cc3b156c40def3a0f1b02821f3edc0047961bf7

Remove dead gradient perspective code

The cool bit here is that Sk4fLinearGradient is now always fast, and never calls the slow
base-class impl.  This means we can rip out Sk4fGradientBase::{mapTs, shadeSpan4f, etc}.

Change-Id: Id3788bc810873b2a209f66efa4187c84b3397e2f
Reviewed-on: https://skia-review.googlesource.com/22366
Reviewed-by: Herb Derby <herb@google.com>
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Florin Malita <fmalita@chromium.org>

src/shaders/gradients/SkGradientShader.cpp

diff --git a/src/shaders/gradients/SkGradientShader.cpp b/src/shaders/gradients/SkGradientShader.cpp
index 0619ef0..6377018 100644
--- a/src/shaders/gradients/SkGradientShader.cpp
+++ b/src/shaders/gradients/SkGradientShader.cpp
@@ -534,12 +534,9 @@
     const SkMatrix& inverse = this->getTotalInverse();
 
     fDstToIndex.setConcat(shader.fPtsToUnit, inverse);
+    SkASSERT(!fDstToIndex.hasPerspective());
 
     fDstToIndexProc = fDstToIndex.getMapXYProc();
-    fDstToIndexClass = (uint8_t)SkShaderBase::Context::ComputeMatrixClass(fDstToIndex);
-
-    // TODO: remove all perspective-related gradient code
-    SkASSERT(fDstToIndexClass == kLinear_MatrixClass);
 
     // now convert our colors in to PMColors
     unsigned paintAlpha = this->getPaintAlpha();