commit 4f19ca325e8d0122e0a04345272d17e674460806
author joshualitt <joshualitt@chromium.org> Thu Jul 30 07:59:20 2015 -0700
committer Commit bot <commit-bot@chromium.org> Thu Jul 30 07:59:20 2015 -0700
tree b2cdf5d2b5b0e02a0b974832bcf85146ae4e7602
parent ef004e1b49ce6ad488ea4444c0eb896ef37c1242

Dont try to draw glyphs with unexpected mask formats

BUG=510931

Review URL: https://codereview.chromium.org/1269743003

src/gpu/GrBatchFontCache.cpp

diff --git a/src/gpu/GrBatchFontCache.cpp b/src/gpu/GrBatchFontCache.cpp
index ecaa91e..dc5b43a 100644
--- a/src/gpu/GrBatchFontCache.cpp
+++ b/src/gpu/GrBatchFontCache.cpp
@@ -196,7 +196,8 @@
 }
 
 bool GrBatchTextStrike::addGlyphToAtlas(GrBatchTarget* batchTarget, GrGlyph* glyph,
-                                        GrFontScaler* scaler, const SkGlyph& skGlyph) {
+                                        GrFontScaler* scaler, const SkGlyph& skGlyph,
+                                        GrMaskFormat expectedMaskFormat) {
     SkASSERT(glyph);
     SkASSERT(scaler);
     SkASSERT(fCache.find(glyph->fPackedID));
@@ -204,7 +205,7 @@
 
     SkAutoUnref ar(SkSafeRef(scaler));
 
-    int bytesPerPixel = GrMaskFormatBytesPerPixel(glyph->fMaskFormat);
+    int bytesPerPixel = GrMaskFormatBytesPerPixel(expectedMaskFormat);
 
     size_t size = glyph->fBounds.area() * bytesPerPixel;
     SkAutoSMalloc<1024> storage(size);
@@ -216,12 +217,13 @@
         }
     } else {
         if (!scaler->getPackedGlyphImage(skGlyph, glyph->width(), glyph->height(),
-                                         glyph->width() * bytesPerPixel, storage.get())) {
+                                         glyph->width() * bytesPerPixel, expectedMaskFormat,
+                                         storage.get())) {
             return false;
         }
     }
 
-    bool success = fBatchFontCache->addToAtlas(this, &glyph->fID, batchTarget, glyph->fMaskFormat,
+    bool success = fBatchFontCache->addToAtlas(this, &glyph->fID, batchTarget, expectedMaskFormat,
                                                glyph->width(), glyph->height(),
                                                storage.get(), &glyph->fAtlasLocation);
     if (success) {