GN: add public headers warnings check.
We already generate skia.h to include all public headers for Fiddle.
This just includes it with -Wunused-parameter turned on as an error.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4901
Change-Id: Ia55a901c09a3c9c9d6d35a43259431dba3532ed9
Reviewed-on: https://skia-review.googlesource.com/4901
Reviewed-by: Derek Sollenberger <djsollen@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>
diff --git a/gn/BUILD.gn b/gn/BUILD.gn
index 3c20c96..60dddff 100644
--- a/gn/BUILD.gn
+++ b/gn/BUILD.gn
@@ -276,7 +276,6 @@
"-Wvla",
"-Wno-deprecated-declarations",
- "-Wno-unused-parameter",
]
cflags_cc += [ "-Wnon-virtual-dtor" ]
@@ -347,6 +346,11 @@
}
}
}
+config("warnings_except_public_headers") {
+ if (!is_win) {
+ cflags = [ "-Wno-unused-parameter" ]
+ }
+}
config("extra_flags") {
cflags = extra_cflags