| commit | 51d04d3c17954f9f8629e7d8a9fe870a7b19962f | [log] [tgz] |
|---|---|---|
| author | halcanary <halcanary@google.com> | Tue Mar 08 13:03:55 2016 -0800 |
| committer | Commit bot <commit-bot@chromium.org> | Tue Mar 08 13:03:55 2016 -0800 |
| tree | 0238b33291f8166aacc332d0c0d5df0c0b3e5dcf | |
| parent | 647cc8474828202c98d540f799742e3074a2aace [diff] |
Revert of SkPDF: Add sk_sp setters; .release() becomes std::move() (patchset #2 id:20001 of https://codereview.chromium.org/1775043002/ ) Reason for revert: https://build.chromium.org/p/client.skia/builders/Linux%20Builder/builds/6405/steps/compile/logs/stdio Original issue's description: > SkPDF: Add sk_sp setters; .release() becomes std::move() > > Note to reviewers: Start with changes to SkPDFTypes.h > > Many places that had a bare pointer owning a reference are refactored to > use a sk_sp. > > There remain several places where a non-owning pointer `T*` should be > replaced with `const sk_sp<T>&` to eliminate the common pattern > `sk_sp<T>(SkRef(x))`. > > Committed: https://skia.googlesource.com/skia/+/9904c9212074279380e21f96575078734dbbd308 TBR=bungeman@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1775143002