| commit | 5352015fa318fc6c25b789cb0a81d2d586d6121f | [log] [tgz] |
|---|---|---|
| author | mtklein <mtklein@chromium.org> | Wed Jan 20 09:53:59 2016 -0800 |
| committer | Commit bot <commit-bot@chromium.org> | Wed Jan 20 09:53:59 2016 -0800 |
| tree | 002b3a85a806779222a3070f8c9bde613859a935 | |
| parent | b1475b0d41efc580207183a4e25d14e920b57360 [diff] [blame] |
Make nanobench --outResultsFile only work with Release builds. It is very, very misleading to report performance numbers for Debug builds. This makes it impossible for us to upload them to perf.skia.org. BUG=skia:4828 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1606323002 Review URL: https://codereview.chromium.org/1606323002
diff --git a/bench/nanobench.cpp b/bench/nanobench.cpp index 7efd858..0a8e735 100644 --- a/bench/nanobench.cpp +++ b/bench/nanobench.cpp
@@ -1054,7 +1054,12 @@ SkAutoTDelete<ResultsWriter> log(new ResultsWriter); if (!FLAGS_outResultsFile.isEmpty()) { +#if defined(SK_RELEASE) log.reset(new NanoJSONResultsWriter(FLAGS_outResultsFile[0])); +#else + SkDebugf("I'm ignoring --outResultsFile because this is a Debug build."); + return 1; +#endif } if (1 == FLAGS_properties.count() % 2) {