commit 537293bf155f5688a8d91d609b5231799e77d81b
author Chris Dalton <csmartdalton@google.com> Mon May 03 15:54:24 2021 -0600
committer Skia Commit-Bot <skia-commit-bot@chromium.org> Mon May 03 23:05:54 2021 +0000
tree c8cb8a5bbd66326f2fb000e36dc99611fca19459
parent bf688645acf9918243b5ed97afd8742813d54035

Don't attempt to use stencil on wrapped, stencil-less targets

We can't attach stencil to a wrapped render target. If we find
ourselves rendering to one that doesn't have stencil already, don't
issue any ops that use stencil.

Bug: chromium:1196353
Bug: skia:11943
Change-Id: I9db93f31a4f8556103be72eb708755e4eaf78136
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/399839
Commit-Queue: Chris Dalton <csmartdalton@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>

src/gpu/GrOpsTask.cpp

diff --git a/src/gpu/GrOpsTask.cpp b/src/gpu/GrOpsTask.cpp
index 862f151..20f97cc 100644
--- a/src/gpu/GrOpsTask.cpp
+++ b/src/gpu/GrOpsTask.cpp
@@ -574,6 +574,7 @@
 
     GrAttachment* stencil = nullptr;
     if (proxy->needsStencil()) {
+        SkASSERT(proxy->canUseStencil(caps));
         if (!flushState->resourceProvider()->attachStencilAttachment(renderTarget,
                                                                      fUsesMSAASurface)) {
             SkDebugf("WARNING: failed to attach a stencil buffer. Rendering will be skipped.\n");