commit 5fa6645dbe4f56a51ce0f59c13c99afb12ff3f5c
author Mike Reed <reed@google.com> Thu Mar 16 09:06:34 2017 -0400
committer Skia Commit-Bot <skia-commit-bot@chromium.org> Thu Mar 16 20:08:50 2017 +0000
tree adad3431f0f3075b3fd1f82d05035075ad5f3fa9
parent c48af934608bbb65650641f66adb51f2102d4274

remove unused VerticesFlags

Deferring removing the flags parameter from the virtuals until a
later CL (as it collides with another related CL)

BUG=skia:6366

Change-Id: I817fae3df03ecebe5ec3532f691ed06deab890e6
Reviewed-on: https://skia-review.googlesource.com/9739
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Mike Reed <reed@google.com>

gm/vertices.cpp

diff --git a/gm/vertices.cpp b/gm/vertices.cpp
index 0d79827..4bf9f87 100644
--- a/gm/vertices.cpp
+++ b/gm/vertices.cpp
@@ -89,7 +89,6 @@
     sk_sp<SkShader>         fShader1;
     sk_sp<SkShader>         fShader2;
     sk_sp<SkColorFilter>    fColorFilter;
-    sk_sp<SkVertices>       fVertices;
     bool                    fUseObject;
     SkScalar                fShaderScale;
 
@@ -104,10 +103,6 @@
         fShader1 = make_shader1(fShaderScale);
         fShader2 = make_shader2();
         fColorFilter = make_color_filter();
-        if (fUseObject) {
-            fVertices = SkVertices::MakeCopy(SkCanvas::kTriangleFan_VertexMode, kMeshVertexCnt,
-                                             fPts, fTexs, fColors, kMeshIndexCnt, kMeshFan);
-        }
     }
 
     SkString onShortName() override {
@@ -175,16 +170,15 @@
                             paint.setShader(shader);
                             paint.setColorFilter(cf);
                             paint.setAlpha(alpha);
+
+                            const SkColor* colors = attrs.fHasColors ? fColors : nullptr;
+                            const SkPoint* texs = attrs.fHasTexs ? fTexs : nullptr;
                             if (fUseObject) {
-                                uint32_t flags = 0;
-                                flags |=
-                                        attrs.fHasColors ? 0 : SkCanvas::kIgnoreColors_VerticesFlag;
-                                flags |= attrs.fHasTexs ? 0
-                                                        : SkCanvas::kIgnoreTexCoords_VerticesFlag;
-                                canvas->drawVertices(fVertices, mode, paint, flags);
+                                auto v = SkVertices::MakeCopy(SkCanvas::kTriangleFan_VertexMode,
+                                                              kMeshVertexCnt, fPts, texs, colors,
+                                                              kMeshIndexCnt, kMeshFan);
+                                canvas->drawVertices(v, mode, paint);
                             } else {
-                                const SkColor* colors = attrs.fHasColors ? fColors : nullptr;
-                                const SkPoint* texs = attrs.fHasTexs ? fTexs : nullptr;
                                 canvas->drawVertices(SkCanvas::kTriangleFan_VertexMode,
                                                      kMeshVertexCnt, fPts, texs, colors, mode,
                                                      kMeshFan, kMeshIndexCnt, paint);
@@ -240,10 +234,6 @@
 
     }
 
-    sk_sp<SkVertices> vertices;
-    if (useObject) {
-        vertices = builder.detach();
-    }
     canvas->save();
     canvas->translate(10, 10);
     for (bool useShader : {false, true}) {
@@ -253,11 +243,13 @@
                 canvas->concat(m);
                 SkPaint paint;
                 paint.setShader(useShader ? shader : nullptr);
+
+                const SkPoint* t = useTex ? texs : nullptr;
                 if (useObject) {
-                    uint32_t flags = useTex ? 0 : SkCanvas::kIgnoreTexCoords_VerticesFlag;
-                    canvas->drawVertices(vertices, SkBlendMode::kModulate, paint, flags);
+                    auto v = SkVertices::MakeCopy(SkCanvas::kTriangles_VertexMode, kMeshVertexCnt,
+                                                  pts, t, colors, kNumTris * 3, indices);
+                    canvas->drawVertices(v, SkBlendMode::kModulate, paint);
                 } else {
-                    const SkPoint* t = useTex ? texs : nullptr;
                     canvas->drawVertices(SkCanvas::kTriangles_VertexMode, kMeshVertexCnt, pts,
                                          t, colors, indices, kNumTris * 3, paint);
                 }