tree 5d3f724d47bf7ea282a85b4cb4ee3f943c8d4165
parent aad96ad1ca3866aae13fb091539171e066ad7f40
author Brian Osman <brianosman@google.com> 1608131974 -0500
committer Skia Commit-Bot <skia-commit-bot@chromium.org> 1608137166 +0000

Fix incorrect 'unreachable code' error in SkSL

This trades one error for another (a potential for incorrect use of
unassigned variables). False-positives for unassigned variables are
straightforward to workaround (and produce code that still looks
reasonable). Working around unreachable code errors is tricky, and
likely to produce non-idiomatic code. This change also makes the data
flow analysis of all loop constructs more similar - for loops were
behaving very differently from while loops.

Note that this effectively a revert of:
  https://skia-review.googlesource.com/c/skia/+/18121/

Change-Id: Ib85d90b22cac8addfb106459c0a5f5616a89c3eb
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/344957
Reviewed-by: Ethan Nicholas <ethannicholas@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>