commit 691b6af907e55250a29a7a2a346b63c2026011c3
author joshualitt <joshualitt@chromium.org> Wed Oct 14 08:04:22 2015 -0700
committer Commit bot <commit-bot@chromium.org> Wed Oct 14 08:04:22 2015 -0700
tree 64d98f4f8ccbc6826974f659051be39890c348bb
parent 8e48ed51baf0099d0a279474f6fc01a3ab857d60

small tidy of benchmarkstream

BUG=skia:

Review URL: https://codereview.chromium.org/1395703002

tools/VisualBench/VisualStreamTimingModule.cpp

diff --git a/tools/VisualBench/VisualStreamTimingModule.cpp b/tools/VisualBench/VisualStreamTimingModule.cpp
index db75890..4148282 100644
--- a/tools/VisualBench/VisualStreamTimingModule.cpp
+++ b/tools/VisualBench/VisualStreamTimingModule.cpp
@@ -16,52 +16,43 @@
     fBenchmarkStream.reset(new VisualBenchmarkStream);
 }
 
-bool VisualStreamTimingModule::nextBenchmarkIfNecessary(SkCanvas* canvas) {
-    if (fBenchmark) {
-        return true;
-    }
-
-    fBenchmark.reset(fBenchmarkStream->next());
-    if (!fBenchmark) {
-        return false;
-    }
-
-    fOwner->clear(canvas, SK_ColorWHITE, 2);
-
-    fBenchmark->delayedSetup();
-    fBenchmark->preTimingHooks(canvas);
-    return true;
-}
-
 void VisualStreamTimingModule::draw(SkCanvas* canvas) {
-    if (!this->nextBenchmarkIfNecessary(canvas)) {
-        SkDebugf("Exiting VisualBench successfully\n");
-        fOwner->closeWindow();
+    if (!fBenchmarkStream->current()) {
+        // this should never happen but just to be safe
         return;
     }
 
     if (fReinitializeBenchmark) {
         fReinitializeBenchmark = false;
-        fBenchmark->preTimingHooks(canvas);
+        fBenchmarkStream->current()->preTimingHooks(canvas);
     }
 
-    this->renderFrame(canvas, fBenchmark, fTSM.loops());
+    this->renderFrame(canvas, fBenchmarkStream->current(), fTSM.loops());
     fOwner->present();
     TimingStateMachine::ParentEvents event = fTSM.nextFrame(fPreWarmBeforeSample);
     switch (event) {
         case TimingStateMachine::kReset_ParentEvents:
-            fBenchmark->postTimingHooks(canvas);
+            fBenchmarkStream->current()->postTimingHooks(canvas);
             fOwner->reset();
             fReinitializeBenchmark = true;
             break;
         case TimingStateMachine::kTiming_ParentEvents:
             break;
         case TimingStateMachine::kTimingFinished_ParentEvents:
-            fBenchmark->postTimingHooks(canvas);
+            fBenchmarkStream->current()->postTimingHooks(canvas);
             fOwner->reset();
-            if (this->timingFinished(fBenchmark, fTSM.loops(), fTSM.lastMeasurement())) {
-                fTSM.nextBenchmark(canvas, fBenchmark);
-                fBenchmark.reset(nullptr);
+            if (this->timingFinished(fBenchmarkStream->current(), fTSM.loops(),
+                                     fTSM.lastMeasurement())) {
+                fTSM.nextBenchmark();
+                if (!fBenchmarkStream->next()) {
+                    SkDebugf("Exiting VisualBench successfully\n");
+                    fOwner->closeWindow();
+                } else {
+                    fOwner->clear(canvas, SK_ColorWHITE, 2);
+
+                    fBenchmarkStream->current()->delayedSetup();
+                    fBenchmarkStream->current()->preTimingHooks(canvas);
+                }
             } else {
                 fReinitializeBenchmark = true;
             }