Comments Style: s/skbug.com/bug.skia.org/
DOCS_PREVIEW= https://skia.org/?cl=1432503003
Review URL: https://codereview.chromium.org/1432503003
diff --git a/DEPS b/DEPS
index 1fc09aa..e4dc54c 100644
--- a/DEPS
+++ b/DEPS
@@ -14,7 +14,7 @@
"third_party/externals/gyp" : "https://chromium.googlesource.com/external/gyp.git@08429da7955a98ef764fafa223dd7de73f654b2d",
"third_party/externals/harfbuzz": "https://skia.googlesource.com/third_party/harfbuzz.git@0.9.35",
"third_party/externals/jsoncpp" : "https://chromium.googlesource.com/external/jsoncpp/jsoncpp.git@1afff032c83e26ddf7f2776e8b43de5ad666c1fa",
- # Slightly ahead of v 0.4.3, to include the fix for skbug.com/4038
+ # Slightly ahead of v 0.4.3, to include the fix for https://bug.skia.org/4038
"third_party/externals/libwebp" : "https://chromium.googlesource.com/webm/libwebp.git@5ff0079ece626f122bfb8e33a5f92b5a68484176",
"third_party/externals/nanomsg" : "https://skia.googlesource.com/third_party/nanomsg.git@0.4-beta",
"third_party/externals/zlib" : "https://chromium.googlesource.com/chromium/src/third_party/zlib@c4e33043fb071b6ea0a153845da625d7ed633d3d",
diff --git a/PRESUBMIT.py b/PRESUBMIT.py
index 4738b9f..e91a222 100644
--- a/PRESUBMIT.py
+++ b/PRESUBMIT.py
@@ -37,7 +37,7 @@
DOCS_PREVIEW_URL = 'https://skia.org/?cl='
-# Path to CQ bots feature is described in skbug.com/4364
+# Path to CQ bots feature is described in https://bug.skia.org/4364
PATH_PREFIX_TO_EXTRA_TRYBOTS = {
# pylint: disable=line-too-long
'cmake/': 'client.skia.compile:Build-Mac10.9-Clang-x86_64-Release-CMake-Trybot,Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot',
@@ -133,7 +133,7 @@
results.append(
output_api.PresubmitError(
'The following files have #if or #ifdef before includes:\n%s\n\n'
- 'See skbug.com/3362 for why this should be fixed.' %
+ 'See https://bug.skia.org/3362 for why this should be fixed.' %
'\n'.join(failing_files)))
return results
diff --git a/bench/nanobench.cpp b/bench/nanobench.cpp
index 264e4a1..95d017c 100644
--- a/bench/nanobench.cpp
+++ b/bench/nanobench.cpp
@@ -519,7 +519,7 @@
// Test png in SkCodec, and optionally on SkImageDecoder. SkImageDecoder is
// disabled by default because it leaks memory.
- // skbug.com/4360
+ // https://bug.skia.org/4360
if ((useCodec || FLAGS_pngBuildTileIndex) && (path.endsWith("png") || path.endsWith("PNG"))) {
return true;
}
@@ -567,7 +567,7 @@
SkDebugf("Could not create decoder for %s. Skipping bench.\n", path.c_str());
return false;
}
- //FIXME: See skbug.com/3921
+ //FIXME: See https://bug.skia.org/3921
if (kIndex_8_SkColorType == colorType || kGray_8_SkColorType == colorType) {
SkDebugf("Cannot use image subset decoder for %s with color type %s. "
"Skipping bench.\n", path.c_str(), color_type_to_str(colorType));
@@ -974,7 +974,7 @@
// (sampleSize*512)x(sampleSize*512).
// There are a few good reasons to only test on power of two sample sizes at this time:
// JPEG decodes using kOriginal_Strategy are broken for non-powers of two.
- // skbug.com/4319
+ // https://bug.skia.org/4319
// All use cases we are aware of only scale by powers of two.
// PNG decodes use the indicated sampling strategy regardless of the sample size, so
// these tests are sufficient to provide good coverage of our scaling options.
diff --git a/dm/DM.cpp b/dm/DM.cpp
index 666fd66..34513dd 100644
--- a/dm/DM.cpp
+++ b/dm/DM.cpp
@@ -318,7 +318,7 @@
switch (codec->getInfo().colorType()) {
case kGray_8_SkColorType:
// FIXME: Is this a long term solution for testing wbmps decodes to kIndex8?
- // Further discussion on this topic is at skbug.com/3683.
+ // Further discussion on this topic is at https://bug.skia.org/3683 .
// This causes us to try to convert grayscale jpegs to kIndex8. We currently
// fail non-fatally in this case.
colorTypes[0] = CodecSrc::kGetFromCanvas_DstColorType;
@@ -345,7 +345,7 @@
}
}
- // skbug.com/4428
+ // https://bug.skia.org/4428
static const char* const exts[] = {
"jpg", "jpeg", "png", "webp",
"JPG", "JPEG", "PNG", "WEBP",
diff --git a/gm/aaclip.cpp b/gm/aaclip.cpp
index b3c39b7..fae6109 100644
--- a/gm/aaclip.cpp
+++ b/gm/aaclip.cpp
@@ -196,7 +196,7 @@
///////////////////////////////////////////////////////////////////////////////////////////////////
-// skbug.com/3716
+// https://bug.skia.org/3716
class ClipCubicGM : public skiagm::GM {
const SkScalar W = 100;
const SkScalar H = 240;
diff --git a/gm/cubicpaths.cpp b/gm/cubicpaths.cpp
index e0f6933..413c517 100644
--- a/gm/cubicpaths.cpp
+++ b/gm/cubicpaths.cpp
@@ -11,7 +11,7 @@
#include "SkPath.h"
#include "SkRandom.h"
-// skbug.com/1316 shows that this cubic, when slightly clipped, creates big
+// https://bug.skia.org/1316 shows that this cubic, when slightly clipped, creates big
// (incorrect) changes to its control points.
class ClippedCubicGM : public skiagm::GM {
public:
diff --git a/gm/draw_bitmap_rect_skbug4374.cpp b/gm/draw_bitmap_rect_skbug4374.cpp
index 8ba600b..582ae3e 100644
--- a/gm/draw_bitmap_rect_skbug4374.cpp
+++ b/gm/draw_bitmap_rect_skbug4374.cpp
@@ -6,7 +6,7 @@
*/
#include "Resources.h"
#include "gm.h"
-// http://skbug.com/4374
+// https://bug.skia.org/4374
DEF_SIMPLE_GM(draw_bitmap_rect_skbug4734, canvas, 64, 64) {
SkBitmap source;
if (GetResourceAsBitmap("randPixels.png", &source)) {
diff --git a/gm/imagefilters.cpp b/gm/imagefilters.cpp
index 8b4deca..1998014 100644
--- a/gm/imagefilters.cpp
+++ b/gm/imagefilters.cpp
@@ -14,7 +14,7 @@
* that we apply the xfermode *after* the image has been created and filtered, and not during
* the creation step (i.e. before it is filtered).
*
- * see skbug.com/3741
+ * see https://bug.skia.org/3741
*/
static void do_draw(SkCanvas* canvas, SkXfermode::Mode mode, SkImageFilter* imf) {
SkAutoCanvasRestore acr(canvas, true);
diff --git a/gm/roundrects.cpp b/gm/roundrects.cpp
index cf3c5e2..b616e4d 100644
--- a/gm/roundrects.cpp
+++ b/gm/roundrects.cpp
@@ -323,7 +323,7 @@
}
}
- // test old entry point (skbug.com/3786)
+ // test old entry point ( https://bug.skia.org/3786 )
{
canvas->save();
diff --git a/gyp/common_conditions.gypi b/gyp/common_conditions.gypi
index 115d94b..e939470 100644
--- a/gyp/common_conditions.gypi
+++ b/gyp/common_conditions.gypi
@@ -123,13 +123,13 @@
'conditions' : [
# Gyp's ninja generator depends on these specially named
# configurations to build 64-bit on Windows.
- # See http://skbug.com/2348
+ # See https://bug.skia.org/2348
#
# We handle the 64- vs 32-bit variations elsewhere, so I think it's
# OK for us to just make these inherit non-archwidth-specific
# configurations without modification.
#
- # See http://skbug.com/2442 : These targets cause problems in the
+ # See https://bug.skia.org/2442 : These targets cause problems in the
# MSVS build, so only include them if gyp is generating a ninja build.
[ '"ninja" in "<!(echo %GYP_GENERATORS%)"', {
'configurations': {
@@ -604,7 +604,7 @@
'defines': [
'SKIA_DLL',
'SKIA_IMPLEMENTATION=1',
- # Needed until we fix skbug.com/2440.
+ # Needed until we fix https://bug.skia.org/2440 .
'SK_SUPPORT_LEGACY_CLIPTOLAYERFLAG',
],
}],
diff --git a/gyp/libwebp_skia.gypi b/gyp/libwebp_skia.gypi
index 9e461fd..6b97cd8 100644
--- a/gyp/libwebp_skia.gypi
+++ b/gyp/libwebp_skia.gypi
@@ -4,7 +4,7 @@
# found in the LICENSE file.
# This allows us to build libwebp with a custom config.h file. It is currently
-# needed to work around skbug.com/4037, but perhaps we might have another need
+# needed to work around https://bug.skia.org/4037 , but perhaps we might have another need
# for it in the future.
{
'include_dirs': [
diff --git a/gyp/skia_for_android_framework_defines.gypi b/gyp/skia_for_android_framework_defines.gypi
index 9fb2bab..70b3f29 100644
--- a/gyp/skia_for_android_framework_defines.gypi
+++ b/gyp/skia_for_android_framework_defines.gypi
@@ -14,7 +14,7 @@
#
'skia_for_android_framework_defines': [
'SK_SUPPORT_LEGACY_UNBALANCED_PIXELREF_LOCKCOUNT',
- # Needed until we fix skbug.com/2440.
+ # Needed until we fix https://bug.skia.org/2440 .
'SK_SUPPORT_LEGACY_CLIPTOLAYERFLAG',
'SK_IGNORE_LINEONLY_AA_CONVEX_PATH_OPTS',
'SK_SUPPORT_LEGACY_GRADIENT_DITHERING',
diff --git a/site/dev/design/pdftheory.md b/site/dev/design/pdftheory.md
index d45cfe2..96b8dbe 100644
--- a/site/dev/design/pdftheory.md
+++ b/site/dev/design/pdftheory.md
@@ -257,7 +257,7 @@
the class. If the requested instance already exists, the existing one
is returned. For obvious reasons, the returned instance should not be
modified. A mechanism to ensure that interned classes are immutable is
-needed. See [issue 2683](http://skbug.com/2683).
+needed. See [issue 2683](https://bug.skia.org/2683).
<a name="Graphic_States"></a>
Graphic States
@@ -372,7 +372,7 @@
coordinate system, so we have to undo any flip to the Skia coordinate
system before drawing these entities. We don’t currently support
inverted paths, so filling an inverted path will give the wrong result
-([issue 241](http://skbug.com/241)). PDF doesn’t draw zero length
+([issue 241](https://bug.skia.org/241)). PDF doesn’t draw zero length
lines that have butt of square caps, so that is emulated.
<a name="Layers"></a>
@@ -573,23 +573,23 @@
Known issues
------------
-* [issue 241](http://skbug.com/241)
+* [issue 241](https://bug.skia.org/241)
As previously noted, a boolean geometry library
would improve clip fidelity in some places, add supported for
inverted fill types, as well as simplify code.
This is fixed, but behind a flag until path ops is production ready.
-* [issue 237](http://skbug.com/237)
+* [issue 237](https://bug.skia.org/237)
SkMaskFilter is not supported.
-* [issue 238](http://skbug.com/238)
+* [issue 238](https://bug.skia.org/238)
SkColorFilter is not supported.
-* [issue 249](http://skbug.com/249)
+* [issue 249](https://bug.skia.org/249)
SrcAtop Xor, and Plus xfer modes are not supported.
-* [issue 240](http://skbug.com/240)
+* [issue 240](https://bug.skia.org/240)
drawVerticies is not implemented.
-* [issue 244](http://skbug.com/244)
+* [issue 244](https://bug.skia.org/244)
Mostly, only TTF fonts are directly supported. (User metrics
show that almost all fonts are truetype.
-* [issue 260](http://skbug.com/260)
+* [issue 260](https://bug.skia.org/260)
Page rotation is accomplished by specifying a different
size page instead of including the appropriate rotation
annotation.
diff --git a/src/codec/SkCodec_libpng.cpp b/src/codec/SkCodec_libpng.cpp
index 54b5787..82c952e 100644
--- a/src/codec/SkCodec_libpng.cpp
+++ b/src/codec/SkCodec_libpng.cpp
@@ -340,7 +340,7 @@
*numberPassesPtr = numberPasses;
}
- // FIXME: Also need to check for sRGB (skbug.com/3471).
+ // FIXME: Also need to check for sRGB ( https://bug.skia.org/3471 ).
if (imageInfo) {
*imageInfo = SkImageInfo::Make(origWidth, origHeight, skColorType, skAlphaType);
diff --git a/src/core/SkConvolver.cpp b/src/core/SkConvolver.cpp
index 72deeaf..28d3ab1 100644
--- a/src/core/SkConvolver.cpp
+++ b/src/core/SkConvolver.cpp
@@ -163,7 +163,7 @@
// thought this was 32 bit only, but subsequent tests show that some 64 bit gcc compiles
// suffer here too.
//
- // Dropping to -O2 disables -ftree-vectorize. GCC 4.6 needs noinline. http://skbug.com/2575
+ // Dropping to -O2 disables -ftree-vectorize. GCC 4.6 needs noinline. https://bug.skia.org/2575
#if SK_HAS_ATTRIBUTE(optimize) && defined(SK_RELEASE)
#define SK_MAYBE_DISABLE_VECTORIZATION __attribute__((optimize("O2"), noinline))
#else
diff --git a/src/core/SkImageCacherator.cpp b/src/core/SkImageCacherator.cpp
index e62c6a1..75fef5a 100644
--- a/src/core/SkImageCacherator.cpp
+++ b/src/core/SkImageCacherator.cpp
@@ -94,7 +94,7 @@
return generator->tryGenerateBitmap(bitmap, fInfo, allocator);
} else {
// need to handle subsetting, so we first generate the full size version, and then
- // "read" from it to get our subset. See skbug.com/4213
+ // "read" from it to get our subset. See https://bug.skia.org/4213
SkBitmap full;
if (!generator->tryGenerateBitmap(&full, genInfo, allocator)) {
diff --git a/src/core/SkImageGenerator.cpp b/src/core/SkImageGenerator.cpp
index 440ae7f..5e40192 100644
--- a/src/core/SkImageGenerator.cpp
+++ b/src/core/SkImageGenerator.cpp
@@ -148,7 +148,7 @@
if (!bitmap->tryAllocPixels(allocator, ctable)) {
// SkResourceCache's custom allcator can'thandle ctables, so it may fail on
// kIndex_8_SkColorTable.
- // skbug.com/4355
+ // https://bug.skia.org/4355
#if 1
// ignroe the allocator, and see if we can succeed without it
if (!bitmap->tryAllocPixels(nullptr, ctable)) {
diff --git a/src/core/SkRRect.cpp b/src/core/SkRRect.cpp
index 2f576fa..ad62e5b 100644
--- a/src/core/SkRRect.cpp
+++ b/src/core/SkRRect.cpp
@@ -202,7 +202,7 @@
}
}
- // skbug.com/3239 -- its possible that we can hit the following inconsistency:
+ // https://bug.skia.org/3239 -- its possible that we can hit the following inconsistency:
// rad == bounds.bottom - bounds.top
// bounds.bottom - radius < bounds.top
// YIKES
diff --git a/src/gpu/GrBufferAllocPool.cpp b/src/gpu/GrBufferAllocPool.cpp
index 210ab44..73b70bf 100644
--- a/src/gpu/GrBufferAllocPool.cpp
+++ b/src/gpu/GrBufferAllocPool.cpp
@@ -320,7 +320,7 @@
GrResourceProvider* rp = fGpu->getContext()->resourceProvider();
static const GrResourceProvider::BufferUsage kUsage = GrResourceProvider::kDynamic_BufferUsage;
- // Shouldn't have to use this flag (http://skbug.com/4156)
+ // Shouldn't have to use this flag (https://bug.skia.org/4156)
static const uint32_t kFlags = GrResourceProvider::kNoPendingIO_Flag;
if (kIndex_BufferType == fBufferType) {
return rp->createIndexBuffer(size, kUsage, kFlags);
diff --git a/src/gpu/GrClipMaskManager.cpp b/src/gpu/GrClipMaskManager.cpp
index 076871c..3e802d7 100644
--- a/src/gpu/GrClipMaskManager.cpp
+++ b/src/gpu/GrClipMaskManager.cpp
@@ -594,7 +594,7 @@
texture, translate, element);
if (Element::kRect_Type != element->getType() && !pr) {
// useSWOnlyPath should now filter out all cases where gpu-side mask merging would
- // be performed (i.e., pr would be NULL for a non-rect path). See skbug.com/4519
+ // be performed (i.e., pr would be NULL for a non-rect path). See https://bug.skia.org/4519
// for rationale and details.
SkASSERT(0);
continue;
diff --git a/src/gpu/GrResourceProvider.cpp b/src/gpu/GrResourceProvider.cpp
index 5fa4e4b..3156814 100644
--- a/src/gpu/GrResourceProvider.cpp
+++ b/src/gpu/GrResourceProvider.cpp
@@ -158,7 +158,7 @@
// We don't want to flush the context so we claim we're in the middle of flushing so as to
// guarantee we do not recieve a texture with pending IO
- // TODO: Determine how to avoid having to do this. (http://skbug.com/4156)
+ // TODO: Determine how to avoid having to do this. (https://bug.skia.org/4156)
static const uint32_t kFlags = GrResourceProvider::kNoPendingIO_Flag;
GrTexture* texture = this->createApproxTexture(desc, kFlags);
if (!texture) {
diff --git a/src/gpu/GrResourceProvider.h b/src/gpu/GrResourceProvider.h
index a709c70..6c57371 100644
--- a/src/gpu/GrResourceProvider.h
+++ b/src/gpu/GrResourceProvider.h
@@ -31,7 +31,7 @@
*
* This currently inherits from GrTextureProvider non-publically to force callers to provider
* make a flags (pendingIO) decision and not use the GrTP methods that don't take flags. This
- * can be relaxed once http://skbug.com/4156 is fixed.
+ * can be relaxed once https://bug.skia.org/4156 is fixed.
*/
class GrResourceProvider : protected GrTextureProvider {
public:
@@ -98,7 +98,7 @@
* set when accessing resources during a GrDrawTarget flush. This includes the execution of
* GrBatch objects. The reason is that these memory operations are done immediately and
* will occur out of order WRT the operations being flushed.
- * Make this automatic: http://skbug.com/4156
+ * Make this automatic: https://bug.skia.org/4156
*/
kNoPendingIO_Flag = kNoPendingIO_ScratchTextureFlag,
};
diff --git a/src/gpu/effects/GrConvexPolyEffect.cpp b/src/gpu/effects/GrConvexPolyEffect.cpp
index d22a347..b37964d 100644
--- a/src/gpu/effects/GrConvexPolyEffect.cpp
+++ b/src/gpu/effects/GrConvexPolyEffect.cpp
@@ -212,7 +212,7 @@
fsBuilder->codeAppend("\t\talpha *= edge;\n");
}
- // Woe is me. See skbug.com/2149.
+ // Woe is me. See https://bug.skia.org/2149 .
if (kTegra2_GrGLRenderer == args.fBuilder->ctxInfo().renderer()) {
fsBuilder->codeAppend("\t\tif (-1.0 == alpha) {\n\t\t\tdiscard;\n\t\t}\n");
}
diff --git a/src/gpu/gl/GrGLCaps.cpp b/src/gpu/gl/GrGLCaps.cpp
index c6a42cf..f5ce0af 100644
--- a/src/gpu/gl/GrGLCaps.cpp
+++ b/src/gpu/gl/GrGLCaps.cpp
@@ -164,7 +164,7 @@
// All the above srgb extensions support toggling srgb writes
fSRGBWriteControl = srgbSupport;
} else {
- // See http://skbug.com/4148 for PowerVR issue.
+ // See https://bug.skia.org/4148 for PowerVR issue.
srgbSupport = kPowerVRRogue_GrGLRenderer != ctxInfo.renderer() &&
(ctxInfo.version() >= GR_GL_VER(3,0) || ctxInfo.hasExtension("GL_EXT_sRGB"));
// ES through 3.1 requires EXT_srgb_write_control to support toggling
@@ -262,7 +262,7 @@
}
}
-#if 0 // Disabled due to http://skbug.com/4454
+#if 0 // Disabled due to https://bug.skia.org/4454
fBindUniformLocationSupport = ctxInfo.hasExtension("GL_CHROMIUM_bind_uniform_location");
#else
fBindUniformLocationSupport = false;
@@ -789,7 +789,7 @@
fConfigTextureSupport[kRGBA_4444_GrPixelConfig] = true;
fConfigTextureSupport[kRGBA_8888_GrPixelConfig] = true;
- // Disable this for now, while we investigate skbug.com/4333
+ // Disable this for now, while we investigate https://bug.skia.org/4333
if (false) {
// Check for 8-bit palette..
GrGLint numFormats;
diff --git a/src/pdf/SkPDFDevice.cpp b/src/pdf/SkPDFDevice.cpp
index c27cc64..6680ea4 100644
--- a/src/pdf/SkPDFDevice.cpp
+++ b/src/pdf/SkPDFDevice.cpp
@@ -572,7 +572,7 @@
// Note that this rendering is done at "screen" resolution (100dpi), not
// printer resolution.
// TODO: It may be possible to express some filters natively using PDF
- // to improve quality and file size (http://skbug.com/3043)
+ // to improve quality and file size (https://bug.skia.org/3043)
// TODO: should we return true if there is a colorfilter?
return layerPaint.getImageFilter() != nullptr;
@@ -1274,7 +1274,7 @@
void SkPDFDevice::drawText(const SkDraw& d, const void* text, size_t len,
SkScalar x, SkScalar y, const SkPaint& srcPaint) {
if (!SkPDFFont::CanEmbedTypeface(srcPaint.getTypeface(), fCanon)) {
- // http://skbug.com/3866
+ // https://bug.skia.org/3866
SkPath path;
srcPaint.getTextPath(text, len, x, y, &path);
this->drawPath(d, path, srcPaint, &SkMatrix::I(), true);
@@ -2349,7 +2349,7 @@
}
if (SkColorFilter* colorFilter = paint.getColorFilter()) {
- // TODO(http://skbug.com/4378): implement colorfilter on other
+ // TODO(https://bug.skia.org/4378): implement colorfilter on other
// draw calls. This code here works for all
// drawBitmap*()/drawImage*() calls amd ImageFilters (which
// rasterize a layer on this backend). Fortuanely, this seems
diff --git a/src/ports/SkFontMgr_fontconfig.cpp b/src/ports/SkFontMgr_fontconfig.cpp
index 7682523..88d4de5 100644
--- a/src/ports/SkFontMgr_fontconfig.cpp
+++ b/src/ports/SkFontMgr_fontconfig.cpp
@@ -61,7 +61,7 @@
namespace {
// Fontconfig is not threadsafe before 2.10.91. Before that, we lock with a global mutex.
-// See http://skbug.com/1497 for background.
+// See https://bug.skia.org/1497 for background.
SK_DECLARE_STATIC_MUTEX(gFCMutex);
#ifdef SK_DEBUG
diff --git a/tests/CodexTest.cpp b/tests/CodexTest.cpp
index 205bd49..febaf7d 100644
--- a/tests/CodexTest.cpp
+++ b/tests/CodexTest.cpp
@@ -196,7 +196,7 @@
}
// FIXME: SkScaledCodec is currently only supported for types used by BRD
-// skbug.com/4428
+// https://bug.skia.org/4428
static bool supports_scaled_codec(const char path[]) {
static const char* const exts[] = {
"jpg", "jpeg", "png", "webp"
diff --git a/tests/ImageDecodingTest.cpp b/tests/ImageDecodingTest.cpp
index 61c89cb..560fda5 100644
--- a/tests/ImageDecodingTest.cpp
+++ b/tests/ImageDecodingTest.cpp
@@ -323,7 +323,7 @@
}
}
}
-#endif // SK_BUILD_FOR_UNIX/ANDROID skbug.com/2388
+#endif // SK_BUILD_FOR_UNIX/ANDROID https://bug.skia.org/2388
#ifdef SK_DEBUG
// Test inside SkScaledBitmapSampler.cpp
diff --git a/tests/ImageTest.cpp b/tests/ImageTest.cpp
index 7cdf5b4..4768b8b 100644
--- a/tests/ImageTest.cpp
+++ b/tests/ImageTest.cpp
@@ -38,7 +38,7 @@
REPORTER_ASSERT(reporter, widthA == b->width());
REPORTER_ASSERT(reporter, heightA == b->height());
#if 0
- // see skbug.com/3965
+ // see https://bug.skia.org/3965
bool AO = a->isOpaque();
bool BO = b->isOpaque();
REPORTER_ASSERT(reporter, AO == BO);
@@ -347,7 +347,7 @@
}
#endif
-// http://skbug.com/4390
+// https://bug.skia.org/4390
DEF_TEST(ImageFromIndex8Bitmap, r) {
SkPMColor pmColors[1] = {SkPreMultiplyColor(SK_ColorWHITE)};
SkBitmap bm;
diff --git a/tests/PathTest.cpp b/tests/PathTest.cpp
index 9c3bcce..eda7f79 100644
--- a/tests/PathTest.cpp
+++ b/tests/PathTest.cpp
@@ -1299,7 +1299,7 @@
check_convexity(reporter, dent, SkPath::kConcave_Convexity);
check_direction(reporter, dent, SkPathPriv::kCW_FirstDirection);
- // http://skbug.com/2235
+ // https://bug.skia.org/2235
SkPath strokedSin;
for (int i = 0; i < 2000; i++) {
SkScalar x = SkIntToScalar(i) / 2;
@@ -1726,7 +1726,7 @@
// Test that multiple move commands do not cause asserts.
// At the time of writing, this would not modify cached convexity. This caused an assert while
- // checking conservative containment again. http://skbug.com/1460
+ // checking conservative containment again. https://bug.skia.org/1460
path.moveTo(SkIntToScalar(100), SkIntToScalar(100));
#if 0
REPORTER_ASSERT(reporter, path.conservativelyContainsRect(SkRect::MakeXYWH(SkIntToScalar(50), 0,
diff --git a/tests/ReadPixelsTest.cpp b/tests/ReadPixelsTest.cpp
index 969617d..97088b7 100644
--- a/tests/ReadPixelsTest.cpp
+++ b/tests/ReadPixelsTest.cpp
@@ -446,7 +446,7 @@
// make_ringed_bitmap was lifted from gm/bleed.cpp, as that GM was what showed the following
// bug when a change was made to SkImage_Raster.cpp. It is possible that other test bitmaps
-// would also tickle skbug.com/4351 but this one is know to do it, so I've pasted the code
+// would also tickle https://bug.skia.org/4351 but this one is know to do it, so I've pasted the code
// here so we have a dependable repro case.
// Create a black&white checked texture with 2 1-pixel rings
@@ -558,7 +558,7 @@
* These two techniques result in the same pixels (ala readPixels)
* but when we draw them (rotated+scaled) we don't always get the same results.
*
- * skbug.com/4351
+ * https://bug.skia.org/4351
*/
DEF_GPUTEST(ReadPixels_Subset_Gpu, reporter, factory) {
GrContext* ctx = factory->get(GrContextFactory::kNative_GLContextType);
diff --git a/tests/RecordDrawTest.cpp b/tests/RecordDrawTest.cpp
index 13be115..5aab91d 100644
--- a/tests/RecordDrawTest.cpp
+++ b/tests/RecordDrawTest.cpp
@@ -197,7 +197,7 @@
REPORTER_ASSERT(r, drawRect->rect == r2);
}
-// A regression test for crbug.com/415468 and skbug.com/2957.
+// A regression test for crbug.com/415468 and https://bug.skia.org/2957 .
//
// This also now serves as a regression test for crbug.com/418417. We used to adjust the
// bounds for the saveLayer, clip, and restore to be greater than the bounds of the picture.
diff --git a/tests/SkResourceCacheTest.cpp b/tests/SkResourceCacheTest.cpp
index 9faddd0..6e8ae40 100644
--- a/tests/SkResourceCacheTest.cpp
+++ b/tests/SkResourceCacheTest.cpp
@@ -26,7 +26,7 @@
}
}
-// http://skbug.com/2894
+// https://bug.skia.org/2894
DEF_TEST(BitmapCache_add_rect, reporter) {
SkResourceCache::DiscardableFactory factory = SkResourceCache::GetDiscardableFactory();
SkBitmap::Allocator* allocator = SkBitmapCache::GetAllocator();
diff --git a/third_party/libwebp/webp/config.h b/third_party/libwebp/webp/config.h
index b01473c..518f18f 100644
--- a/third_party/libwebp/webp/config.h
+++ b/third_party/libwebp/webp/config.h
@@ -5,7 +5,7 @@
* found in the LICENSE file.
*/
-// FIXME: Workaround for skbug.com/4037
+// FIXME: Workaround for https://bug.skia.org/4037
// Some of our test machines have an older version of clang that does not
// have
// __builtin_bswap16
diff --git a/tools/nanobench_flags.py b/tools/nanobench_flags.py
index 471c1d9..2d5516f 100755
--- a/tools/nanobench_flags.py
+++ b/tools/nanobench_flags.py
@@ -83,8 +83,8 @@
# the 32-bit GCE bots run out of memory in DM when running these large images
# so defensively disable them in nanobench, too.
# FIXME (scroggo): This may have just been due to SkImageDecoder's
- # buildTileIndex leaking memory (skbug.com/4360). That is disabled by
- # default for nanobench, so we may not need this.
+ # buildTileIndex leaking memory (https://bug.skia.org/4360). That is
+ # disabled by default for nanobench, so we may not need this.
# FIXME (scroggo): Share image blacklists between dm and nanobench?
if 'x86' in bot and not 'x86-64' in bot:
match.append('~interlaced1.png')
diff --git a/tools/skpdiff/SkDiffContext.cpp b/tools/skpdiff/SkDiffContext.cpp
index 8da346e..e76237a 100644
--- a/tools/skpdiff/SkDiffContext.cpp
+++ b/tools/skpdiff/SkDiffContext.cpp
@@ -145,7 +145,7 @@
if (!differ->diff(&baselineBitmap, &testBitmap, bitmapsToCreate, &diffData.fResult)) {
// if the diff failed, record -1 as the result
// TODO(djsollen): Record more detailed information about exactly what failed.
- // (Image dimension mismatch? etc.) See http://skbug.com/2710 ('make skpdiff
+ // (Image dimension mismatch? etc.) See https://bug.skia.org/2710 ('make skpdiff
// report more detail when it fails to compare two images')
diffData.fResult.result = -1;
continue;
@@ -179,7 +179,7 @@
// a particular differ and storing them as toplevel fields within
// newRecord, we should extend outputRecords() to report optional
// fields for each differ (not just "result" and "pointsOfInterest").
- // See http://skbug.com/2712 ('allow skpdiff to report different sets
+ // See https://bug.skia.org/2712 ('allow skpdiff to report different sets
// of result fields for different comparison algorithms')
newRecord->fMaxRedDiff = diffData.fResult.maxRedDiff;
newRecord->fMaxGreenDiff = diffData.fResult.maxGreenDiff;
@@ -272,7 +272,7 @@
// TODO(djsollen): Would it be better to use the jsoncpp library to write out the JSON?
// This manual approach is probably more efficient, but it sure is ugly.
- // See http://skbug.com/2713 ('make skpdiff use jsoncpp library to write out
+ // See https://bug.skia.org/2713 ('make skpdiff use jsoncpp library to write out
// JSON output, instead of manual writeText() calls?')
stream.writeText(" \"records\": [\n");
while (currentRecord) {
diff --git a/tools/skpdiff/SkDiffContext.h b/tools/skpdiff/SkDiffContext.h
index 9347d26..4a878b8 100644
--- a/tools/skpdiff/SkDiffContext.h
+++ b/tools/skpdiff/SkDiffContext.h
@@ -165,7 +165,7 @@
struct DiffRecord {
// TODO(djsollen): Some of these fields are required, while others are optional
// (e.g., fRgbDiffPath is only filled in if SkDifferentPixelsMetric
- // was run). Figure out a way to note that. See http://skbug.com/2712
+ // was run). Figure out a way to note that. See https://bug.skia.org/2712
// ('allow skpdiff to report different sets of result fields for
// different comparison algorithms')
SkString fCommonName;
diff --git a/tools/skpdiff/SkImageDiffer.h b/tools/skpdiff/SkImageDiffer.h
index 1f9ffd1..7960057 100644
--- a/tools/skpdiff/SkImageDiffer.h
+++ b/tools/skpdiff/SkImageDiffer.h
@@ -25,7 +25,7 @@
double result;
int poiCount;
// TODO(djsollen): Figure out a way that the differ can report which of the
- // optional fields it has filled in. See http://skbug.com/2712 ('allow
+ // optional fields it has filled in. See https://bug.skia.org/2712 ('allow
// skpdiff to report different sets of result fields for different comparison algorithms')
SkBitmap poiAlphaMask; // optional
SkBitmap rgbDiffBitmap; // optional
diff --git a/tools/skpdiff/skpdiff_main.cpp b/tools/skpdiff/skpdiff_main.cpp
index 90b4f71..82043c4 100644
--- a/tools/skpdiff/skpdiff_main.cpp
+++ b/tools/skpdiff/skpdiff_main.cpp
@@ -8,7 +8,7 @@
// TODO(djsollen): Rename this whole package (perhaps to "SkMultiDiffer").
// It's not just for "pdiff" (perceptual diffs)--it's a harness that allows
// the execution of an arbitrary set of difference algorithms.
-// See http://skbug.com/2711 ('rename skpdiff')
+// See https://bug.skia.org/2711 ('rename skpdiff')
#include "SkTypes.h"