commit 6a204db32c49af517bb475ee3ea07d06dce72203
author Brian Osman <brianosman@google.com> Thu Oct 08 09:29:02 2020 -0400
committer Skia Commit-Bot <skia-commit-bot@chromium.org> Thu Oct 08 14:14:39 2020 +0000
tree 2aa885abc9a09990e7663a339b096fa2509aeb70
parent dd21816b00f5cc39483d1813f3d09b58fc61222d

Change interface block's fVariable from ref to pointer

The next pre-include refactor will require cloning InterfaceBlocks, and
re-targeting the variable.

Change-Id: Iccfc1f39789fcd572199682386cd612500334061
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/323890
Commit-Queue: Brian Osman <brianosman@google.com>
Commit-Queue: John Stiles <johnstiles@google.com>
Auto-Submit: Brian Osman <brianosman@google.com>
Reviewed-by: John Stiles <johnstiles@google.com>

src/sksl/SkSLMetalCodeGenerator.cpp

diff --git a/src/sksl/SkSLMetalCodeGenerator.cpp b/src/sksl/SkSLMetalCodeGenerator.cpp
index 980d499..86a4bc2 100644
--- a/src/sksl/SkSLMetalCodeGenerator.cpp
+++ b/src/sksl/SkSLMetalCodeGenerator.cpp
@@ -983,11 +983,11 @@
                     continue;
                 }
                 this->write(", constant ");
-                this->writeType(intf.fVariable.type());
+                this->writeType(intf.fVariable->type());
                 this->write("& " );
                 this->write(fInterfaceBlockNameMap[&intf]);
                 this->write(" [[buffer(");
-                this->write(to_string(intf.fVariable.modifiers().fLayout.fBinding));
+                this->write(to_string(intf.fVariable->modifiers().fLayout.fBinding));
                 this->write(")]]");
             }
         }
@@ -1113,10 +1113,10 @@
     if ("sk_PerVertex" == intf.fTypeName) {
         return;
     }
-    this->writeModifiers(intf.fVariable.modifiers(), true);
+    this->writeModifiers(intf.fVariable->modifiers(), true);
     this->write("struct ");
     this->writeLine(intf.fTypeName + " {");
-    const Type* structType = &intf.fVariable.type();
+    const Type* structType = &intf.fVariable->type();
     fWrittenStructs.push_back(structType);
     while (structType->typeKind() == Type::TypeKind::kArray) {
         structType = &structType->componentType();