commit 6ad9909fb7ccc973f35bbd222b0f424b8c3df0d2
author Mike Klein <mtklein@chromium.org> Wed Oct 26 10:35:22 2016 -0400
committer Skia Commit-Bot <skia-commit-bot@chromium.org> Wed Oct 26 15:57:09 2016 +0000
tree e5a4eebf8e097156272d1abf8cb4ed0aad9130c4
parent f93f5151612a4b1adfe1dad0490bd1c01ee73598

Turn on -Wrange-loop-analysis.

-Wrange-loop-analysis triggers when we use a new-style for loop in a way that appears to unintentionally call a copy constructor on each non-trivial loop element instead of operating on them by reference.


BUG=skia:

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4000

Change-Id: If9e1b7fcc1f2789ae03c41c17abb17e60d564a8b
Reviewed-on: https://skia-review.googlesource.com/4000
Reviewed-by: Ethan Nicholas <ethannicholas@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>

tests/FontMgrTest.cpp

diff --git a/tests/FontMgrTest.cpp b/tests/FontMgrTest.cpp
index c8c8b94..172bff3 100644
--- a/tests/FontMgrTest.cpp
+++ b/tests/FontMgrTest.cpp
@@ -690,7 +690,7 @@
     };
 
     for (StyleSetTest& test : tests) {
-        for (const StyleSetTest::Case testCase : test.cases) {
+        for (const StyleSetTest::Case& testCase : test.cases) {
             SkAutoTUnref<SkTypeface> typeface(test.styleSet.matchStyle(testCase.pattern));
             if (typeface) {
                 REPORTER_ASSERT(reporter, typeface->fontStyle() == testCase.expectedResult);