commit 6aeb8e84dfb474de6482062df9a2766a65cd817b
author Chris Dalton <csmartdalton@google.com> Tue Aug 27 11:52:19 2019 -0600
committer Skia Commit-Bot <skia-commit-bot@chromium.org> Tue Aug 27 18:24:27 2019 +0000
tree 8a1c2d20400bea39914412d0cb4f2ab397a3b619
parent 674ee74e88d710e4256810125828993485f25bff

Add renderTasks to the DAG before calling addDependency

This makes sure the dependent task is already in the DAG before a
textureResolveRenderTask calls "addBeforeLast".

Bug: skia:
Change-Id: Ib276d41c386fd3d5a237212d60d7bf67a662e419
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/237257
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Chris Dalton <csmartdalton@google.com>

src/gpu/GrRenderTask.cpp

diff --git a/src/gpu/GrRenderTask.cpp b/src/gpu/GrRenderTask.cpp
index 639f4cf..9541408 100644
--- a/src/gpu/GrRenderTask.cpp
+++ b/src/gpu/GrRenderTask.cpp
@@ -123,8 +123,8 @@
         GrRenderTask* textureResolveTask = textureResolveManager.newTextureResolveRenderTask(
                 sk_ref_sp(textureProxy), GrTextureResolveFlags::kMipMaps, caps);
 
-        // The GrTextureResolveRenderTask factory should have called addDependency (in this
-        // instance, recursively) on the textureProxy.
+        // GrTextureResolveRenderTask::init should have called addDependency (in this instance,
+        // recursively) on the textureProxy.
         SkASSERT(!dependedOnTask || textureResolveTask->dependsOn(dependedOnTask));
         SkASSERT(!textureProxy->texPriv().isDeferred() ||
                  textureResolveTask->fDeferredProxies.back() == textureProxy);