| commit | 6c7b104b4c08ae2332a6ce3c8c906da4e8c51e5f | [log] [tgz] |
|---|---|---|
| author | mtklein <mtklein@chromium.org> | Thu Nov 19 09:40:48 2015 -0800 |
| committer | Commit bot <commit-bot@chromium.org> | Thu Nov 19 09:40:48 2015 -0800 |
| tree | 40fd55186fda91bcb743bfd9c63ef9913b0ff595 | |
| parent | c11a527cd06a0a6c2cef0d986ea8f5ef0989505a [diff] |
Fix UB in SkDivBits DIVBITS_ITER was shifting bits up into the sign bit, which is a no-no. This turns numer into a uint32_t to make those defined, and adds a few notes. x >= 0 is always true for unsigned x, so we needed a few small logic refactors. BUG=skia:3562 Committed: https://skia.googlesource.com/skia/+/988adddd48322bfa3e3cb0c017cfce71fbbf1123 Review URL: https://codereview.chromium.org/1455163004