| commit | 774b566c13088006f4ca8c358c60352d76795678 | [log] [tgz] |
|---|---|---|
| author | Ben Wagner <bungeman@google.com> | Tue Sep 18 21:22:37 2018 +0000 |
| committer | Skia Commit-Bot <skia-commit-bot@chromium.org> | Tue Sep 18 21:22:42 2018 +0000 |
| tree | 7ba943e93dd49a66398256d161d714f3fd127553 | |
| parent | c03a86affc966a3ff83bef91abde3a375122ff14 [diff] |
Revert "Reland "implement SkPixmap::erase() with draws"" This reverts commit 4a9631c1869656667d66372990fa146be30ccf6f. Reason for revert: Chrome for Android in roll? https://chromium-review.googlesource.com/c/chromium/src/+/1231494 Original change's description: > Reland "implement SkPixmap::erase() with draws" > > This is a reland of 42f29f11817f9829b92dbf52d77f1447fbfc5ed0 > > The original had to be reverted because of a buggy Chromium unit test, > now fixed. I also took the opportunity to implement this with SkDraw > rather than SkCanvas. > > Original change's description: > > implement SkPixmap::erase() with draws > > > > I don't want to have to maintain yet another switch on SkColorType. > > > > This should also make color management a bit clearer? > > > > Change-Id: I1508e0c30670b1987972f7eeba2dd6d23591c531 > > Reviewed-on: https://skia-review.googlesource.com/154862 > > Commit-Queue: Mike Klein <mtklein@google.com> > > Reviewed-by: Brian Osman <brianosman@google.com> > > Change-Id: I6bc071e8a6025723d47f2ad5f6fb7f8fa5dccc2b > Reviewed-on: https://skia-review.googlesource.com/155240 > Reviewed-by: Brian Osman <brianosman@google.com> > Commit-Queue: Mike Klein <mtklein@google.com> TBR=mtklein@google.com,brianosman@google.com,reed@google.com Change-Id: I1ce2ae01253e95da28f7d5b4bd82b59775e9fef8 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://skia-review.googlesource.com/155403 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Ben Wagner <bungeman@google.com>