| commit | 78559a78f9d3e6444f8c0c9443696699703d6531 | [log] [tgz] |
|---|---|---|
| author | mtklein <mtklein@chromium.org> | Mon Aug 22 08:53:45 2016 -0700 |
| committer | Commit bot <commit-bot@chromium.org> | Mon Aug 22 08:53:45 2016 -0700 |
| tree | 22ddd055715ef77a469f66df999320cc7a5edcbb | |
| parent | dd3259eb95c3b47e11eefa3b176365a112a32b48 [diff] |
Use ARMv8 CRC32 instructions for SkOpts::hash(). For large inputs, this runs ~11x faster than Murmur3. My bench drops from 1µs to 88ns. Like x86-64, this runs fastest if we work in 24 byte chunks. 16 byte chunks run at about 0.75x this speed, 8 byte chunks at about 0.4x (which would still be about 5x faster than Murmur3). This'll require plumbing support for opts_crc32 into Chrome first before it can roll. perf.skia.org charts we want to watch: https://perf.skia.org/#5490 Seach for compute_hash in these logs to see the difference: baseline: https://luci-milo.appspot.com/swarming/task/30ba22f3dfe30e10/steps/nanobench/0/stdout trybot: https://luci-milo.appspot.com/swarming/task/30bbc406cbf62d10/steps/nanobench/0/stdout BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2260823002 CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot Review-Url: https://codereview.chromium.org/2260823002