commit 7a808d618e90e216cf4fa6369f658350319deb02
author Hal Canary <halcanary@google.com> Fri Jun 16 13:38:34 2017 -0400
committer Skia Commit-Bot <skia-commit-bot@chromium.org> Fri Jun 16 21:30:37 2017 +0000
tree 1de807337207c8bb60e30bcf8686689c64f44b83
parent 93323eb401dc9003dda881ac83222d115151947f

ICC: SkICC::WriteToICC Description Tag is function of input

BUG=skia:6720
Change-Id: I038079a6e15f884eb77b84d9c7c75f6b7fbedd37
Reviewed-on: https://skia-review.googlesource.com/20152
Commit-Queue: Hal Canary <halcanary@google.com>
Reviewed-by: Matt Sarett <msarett@google.com>

tests/ICCTest.cpp

diff --git a/tests/ICCTest.cpp b/tests/ICCTest.cpp
index 5d541bd..3c855fb 100644
--- a/tests/ICCTest.cpp
+++ b/tests/ICCTest.cpp
@@ -11,6 +11,7 @@
 #include "SkColorSpace_XYZ.h"
 #include "SkData.h"
 #include "SkICC.h"
+#include "SkICCPriv.h"
 #include "SkMatrix44.h"
 #include "SkStream.h"
 #include "Test.h"
@@ -112,6 +113,14 @@
     REPORTER_ASSERT(r, SkColorSpace::Equals(reference, colorSpace.get()));
 }
 
+template <typename T>
+static bool equal(const SkTArray<T>& u, const SkTArray<T>& v) {
+    if (u.count() != v.count()) {
+        return false;
+    }
+    return u.count() == 0 || 0 == memcmp(&u[0], &v[0], sizeof(T) * u.count());
+}
+
 DEF_TEST(ICC_WriteICC, r) {
     SkColorSpaceTransferFn adobeFn;
     adobeFn.fA = 1.0f;
@@ -138,6 +147,16 @@
     srgbMatrix.set3x3RowMajorf(gSRGB_toXYZD50);
     test_write_icc(r, srgbFn, srgbMatrix, SkColorSpace::MakeSRGB().get(),
                    false);
+
+    SkTArray<uint8_t> adobeTag;
+    adobeTag.reset(SkToInt(SkICCWriteDescriptionTag(nullptr, adobeFn, adobeMatrix)));
+    SkICCWriteDescriptionTag(&adobeTag[0], adobeFn, adobeMatrix);
+
+    SkTArray<uint8_t> srgbTag;
+    srgbTag.reset(SkToInt(SkICCWriteDescriptionTag(nullptr, srgbFn, srgbMatrix)));
+    SkICCWriteDescriptionTag(&srgbTag[0], srgbFn, srgbMatrix);
+
+    REPORTER_ASSERT(r, !equal(adobeTag, srgbTag));
 }
 
 static inline void test_raw_transfer_fn(skiatest::Reporter* r, SkICC* icc) {