Return cropBitmap
cropBitmap returns 'true' on success and 'false' on failure.
Propagate its return value so that cascading failures can be avoided.
Signed-off-by: Mykola Kondratenko <mykola.kondratenko@sonymobile.com>
BUG=skia:
Review URL: https://codereview.chromium.org/1088093003
diff --git a/src/images/SkImageDecoder_libjpeg.cpp b/src/images/SkImageDecoder_libjpeg.cpp
index 14df6e3..d5303ec 100644
--- a/src/images/SkImageDecoder_libjpeg.cpp
+++ b/src/images/SkImageDecoder_libjpeg.cpp
@@ -1125,11 +1125,11 @@
if (swapOnly) {
bm->swap(bitmap);
- } else {
- cropBitmap(bm, &bitmap, actualSampleSize, region.x(), region.y(),
- region.width(), region.height(), startX, startY);
+ return true;
}
- return true;
+
+ return cropBitmap(bm, &bitmap, actualSampleSize, region.x(), region.y(),
+ region.width(), region.height(), startX, startY);
}
#endif
@@ -1184,11 +1184,10 @@
}
if (swapOnly) {
bm->swap(bitmap);
- } else {
- cropBitmap(bm, &bitmap, actualSampleSize, region.x(), region.y(),
- region.width(), region.height(), startX, startY);
+ return true;
}
- return true;
+ return cropBitmap(bm, &bitmap, actualSampleSize, region.x(), region.y(),
+ region.width(), region.height(), startX, startY);
}
#endif