[svg] Implement 'display:none'
The full 'display' presentation attribute [1] has a number of settings
that we likely don't want to support. However, 'display:none' has some
practical uses and is easy enough to support. This progresses some
local tests as well as a few W3C tests.
[1] https://www.w3.org/TR/SVG11/painting.html#DisplayProperty
Bug: skia:10842
Change-Id: I60fef959fb45c3cfb229b85b720dfa69fc458bc3
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/403438
Commit-Queue: Tyler Denniston <tdenniston@google.com>
Reviewed-by: Florin Malita <fmalita@chromium.org>
diff --git a/modules/svg/src/SkSVGAttributeParser.cpp b/modules/svg/src/SkSVGAttributeParser.cpp
index 6fdb90d..f1e412d 100644
--- a/modules/svg/src/SkSVGAttributeParser.cpp
+++ b/modules/svg/src/SkSVGAttributeParser.cpp
@@ -963,3 +963,26 @@
return this->parseEnumMap(gColorspaceMap, colorspace) && this->parseEOSToken();
}
+
+// https://www.w3.org/TR/SVG11/painting.html#DisplayProperty
+template <>
+bool SkSVGAttributeParser::parse(SkSVGDisplay* display) {
+ static const struct {
+ SkSVGDisplay fType;
+ const char* fName;
+ } gDisplayInfo[] = {
+ { SkSVGDisplay::kInline, "inline" },
+ { SkSVGDisplay::kNone , "none" },
+ };
+
+ bool parsedValue = false;
+ for (const auto& parseInfo : gDisplayInfo) {
+ if (this->parseExpectedStringToken(parseInfo.fName)) {
+ *display = SkSVGDisplay(parseInfo.fType);
+ parsedValue = true;
+ break;
+ }
+ }
+
+ return parsedValue && this->parseEOSToken();
+}