commit 81a8d282d356667aab7bc8c0513da81bb1c5f3c4
author Mike Klein <mtklein@google.com> Wed Nov 06 15:11:01 2019 -0600
committer Skia Commit-Bot <skia-commit-bot@chromium.org> Thu Nov 07 18:55:14 2019 +0000
tree d93f01b14248860fe5fca1d9b4b631aabe5b2493
parent 05f6a01bf9fd25be9e5fff4af5505c3945058b1d

Reland "hook up float comparisons to x86 JIT"

This is a reland of 12cea8d6c429d06425be97af31db7c31655e5290

Now implementing float comparisons on ARM also.
Only vaguely tricky thing is that x!=y is ~(x==y).

Original change's description:
> hook up float comparisons to x86 JIT
>
> This gets the draws in gm/skvm.cpp all JITing again,
> and in one of the unit tests.
>
> (Everything draws the same of course.)
>
> Change-Id: Iada28690d9df78f9d444ee3765e21beb29239672
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/253166
> Auto-Submit: Mike Klein <mtklein@google.com>
> Reviewed-by: Mike Klein <mtklein@google.com>
> Commit-Queue: Mike Klein <mtklein@google.com>

Cq-Include-Trybots: skia.primary:Test-Android-Clang-NVIDIA_Shield-CPU-TegraX1-arm64-Debug-All-Android
Change-Id: I771b8a327a958db8a0d509d55863ade935a00035
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/253401
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>

tests/SkVMTest.cpp

diff --git a/tests/SkVMTest.cpp b/tests/SkVMTest.cpp
index cd598d1..86a2ae5 100644
--- a/tests/SkVMTest.cpp
+++ b/tests/SkVMTest.cpp
@@ -466,7 +466,7 @@
         b.store32(b.varying<int>(), m);
     }
 
-    test_interpreter_only(r, b.done(), [&](const skvm::Program& program) {
+    test_jit_and_interpreter(r, b.done(), [&](const skvm::Program& program) {
         float in[] = { 0,1,2,3,4,5,6,7,8,9 };
         int out[SK_ARRAY_COUNT(in)];
 
@@ -1047,6 +1047,7 @@
         a.eor16b(A::v4, A::v3, A::v1);
         a.bic16b(A::v4, A::v3, A::v1);
         a.bsl16b(A::v4, A::v3, A::v1);
+        a.not16b(A::v4, A::v3);
 
         a.add4s(A::v4, A::v3, A::v1);
         a.sub4s(A::v4, A::v3, A::v1);
@@ -1064,12 +1065,17 @@
         a.fdiv4s(A::v4, A::v3, A::v1);
 
         a.fmla4s(A::v4, A::v3, A::v1);
+
+        a.fcmeq4s(A::v4, A::v3, A::v1);
+        a.fcmgt4s(A::v4, A::v3, A::v1);
+        a.fcmge4s(A::v4, A::v3, A::v1);
     },{
         0x64,0x1c,0x21,0x4e,
         0x64,0x1c,0xa1,0x4e,
         0x64,0x1c,0x21,0x6e,
         0x64,0x1c,0x61,0x4e,
         0x64,0x1c,0x61,0x6e,
+        0x64,0x58,0x20,0x6e,
 
         0x64,0x84,0xa1,0x4e,
         0x64,0x84,0xa1,0x6e,
@@ -1087,6 +1093,10 @@
         0x64,0xfc,0x21,0x6e,
 
         0x64,0xcc,0x21,0x4e,
+
+        0x64,0xe4,0x21,0x4e,
+        0x64,0xe4,0xa1,0x6e,
+        0x64,0xe4,0x21,0x6e,
     });
 
     test_asm(r, [&](A& a) {