commit 88b138da99328b04cae9a8ee19c3882b8847a550
author halcanary <halcanary@google.com> Thu Aug 11 12:25:09 2016 -0700
committer Commit bot <commit-bot@chromium.org> Thu Aug 11 12:25:09 2016 -0700
tree e4270425495cb358756e70bdb63c51fe36dc737b
parent 86e7626f080028edd58f4b326e0ba9fa83c4208e

SkPDF: Subset Type3 (fallback) font

Motivation: significant file-size reduction.

Also: SkPDFFont::subsetFont() returns a sk_sp<SkPDFObject>
rather than a SkPDFFont*.

SkPDFType3Font constructor no longer populates font info;
relies on subsetting.

SkPDFFont::Create is easier to read

Also: SkPDFType3Font are scaled by emSize rather than 1000.

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2231483002

Review-Url: https://codereview.chromium.org/2231483002

src/pdf/SkPDFDocument.cpp

diff --git a/src/pdf/SkPDFDocument.cpp b/src/pdf/SkPDFDocument.cpp
index 7723caf..4a577fc 100644
--- a/src/pdf/SkPDFDocument.cpp
+++ b/src/pdf/SkPDFDocument.cpp
@@ -483,8 +483,8 @@
 
     // Build font subsetting info before calling addObjectRecursively().
     for (const auto& entry : fGlyphUsage) {
-        sk_sp<SkPDFFont> subsetFont(
-                entry.fFont->getFontSubset(&entry.fGlyphSet));
+        sk_sp<SkPDFObject> subsetFont =
+            entry.fFont->getFontSubset(&entry.fGlyphSet);
         if (subsetFont) {
             fObjectSerializer.fSubstituteMap.setSubstitute(
                     entry.fFont, subsetFont.get());