| commit | 8afa554414b3fed2cd970249946e3986473b5580 | [log] [tgz] |
|---|---|---|
| author | Mike Klein <mtklein@google.com> | Tue May 22 12:19:13 2018 +0000 |
| committer | Skia Commit-Bot <skia-commit-bot@chromium.org> | Tue May 22 12:19:25 2018 +0000 |
| tree | cecc57084a25618660e317c218871336235ec511 | |
| parent | e62b5c3d100ed4ba8df52416fa47f5b36d4bb177 [diff] [blame] |
Revert "remove fragile hack in addOval to avoid computing bounds" This reverts commit bc721ba4be626e3ba753f55341a7019d98044102. Reason for revert: I think we'll want to reland with guards for layout tests. https://test-results.appspot.com/data/layout_results/linux_trusty_blink_rel/29630/layout-test-results/results.html Original change's description: > remove fragile hack in addOval to avoid computing bounds > > Bug: skia: > Change-Id: Ide917f54633370f1fce46a115fa923794b981e2e > Reviewed-on: https://skia-review.googlesource.com/129461 > Reviewed-by: Mike Klein <mtklein@google.com> > Commit-Queue: Mike Reed <reed@google.com> TBR=mtklein@google.com,reed@google.com Change-Id: Ibadac8bbeca2b162d696e7cca51d580121afe71f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia: Reviewed-on: https://skia-review.googlesource.com/129442 Reviewed-by: Mike Klein <mtklein@google.com> Commit-Queue: Mike Klein <mtklein@google.com>
diff --git a/src/core/SkPath.cpp b/src/core/SkPath.cpp index 7a0f828..510efd6 100644 --- a/src/core/SkPath.cpp +++ b/src/core/SkPath.cpp
@@ -1252,9 +1252,7 @@ } SkAutoDisableDirectionCheck addc(this); - // unlike addRect(), we can't use SkAutoPathBoundsUpdate here, since even with a finite - // bounds, we might (due to an overflow in intermediate calculations) create a nonfinite - // path. + SkAutoPathBoundsUpdate apbu(this, oval); SkDEBUGCODE(int initialVerbCount = this->countVerbs()); const int kVerbs = 6; // moveTo + 4x conicTo + close