commit | 8b720090ef31aaa27a6f23b7b6128ba135fef8e3 | [log] [tgz] |
---|---|---|
author | Leon Scroggins III <scroggo@google.com> | Tue Oct 16 15:29:11 2018 -0400 |
committer | JP Sugarbroad <jpsugar@google.com> | Thu Dec 06 00:35:12 2018 -0800 |
tree | bdc36530a192d386b322f39e8cac44d465411c48 | |
parent | a444ec7c43a2e295f2f9ee2a405612beaf275bbe [diff] |
RESTRICT AUTOMERGE: Fix uninitialized errors in SkPngCodec Bug: 117838472 Test: Iae4d7f393c892111b12282c5eae31d79912721f9 - Initialize rowsDecoded in SkSampledCodec. Otherwise, fillIncompleteImage may be called with an uninitialized value. This change was originally uploaded to AOSP as https://android-review.googlesource.com/c/platform/external/skia/+/785816 - If SkPngCodec hits an error, still transform from the interlace buffer (if needed) and set rowsDecoded properly. - Do not copy uninitialized memory from the interlace buffer. - Make BRD treat kErrorInInput like kIncompleteInput. The two errors are different for the purposes of incremental decode. For a direct decode, they're essentially the same - part was decoded, but then the decode was interrupted. This allows testing images with errors on the bots without reporting a failure. Originally uploaded as https://skia-review.googlesource.com/c/skia/+/161822 - Also includes SkPngCodec SafetyNet logging from https://skia-review.googlesource.com/c/skia/+/170354 Change-Id: Ie170abf65393feb4edba60aa941f2783fe18cd8b (cherry picked from commit fc165d5cccf133574058cd0c5ba3a95ea6ad2bb8)