| commit | 8ebaa7171246eb5b3a7dd65ba42ef42a888508d7 | [log] [tgz] |
|---|---|---|
| author | fmalita <fmalita@chromium.org> | Thu Nov 20 20:44:04 2014 -0800 |
| committer | Commit bot <commit-bot@chromium.org> | Thu Nov 20 20:44:04 2014 -0800 |
| tree | 53caf01479f56733a51197521047592b8ffdb762 | |
| parent | 60b24d0df70392a89dfd7d4a8ae58411812c3067 [diff] [blame] |
Revert of SkCanvas::clear() should call down to devices even when the clip is empty. (patchset #1 id:1 of https://codereview.chromium.org/735233003/) Reason for revert: Chrome unit_tests failures on Mac & Win, blocking the roll: http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/5613 Original issue's description: > SkCanvas::clear() should call down to devices even when the clip is empty. > > SkDrawIter had a lovely, completely unused, option for this. Oversight? > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/378e70d8e561b72a904286ea231946f5c8345b9a TBR=reed@google.com,mtklein@google.com,mtklein@chromium.org NOTREECHECKS=true NOTRY=true BUG=skia: Review URL: https://codereview.chromium.org/748733002
diff --git a/src/core/SkCanvas.cpp b/src/core/SkCanvas.cpp index bf736e9..3bf1ad9 100644 --- a/src/core/SkCanvas.cpp +++ b/src/core/SkCanvas.cpp
@@ -1707,7 +1707,7 @@ ////////////////////////////////////////////////////////////////////////////// void SkCanvas::clear(SkColor color) { - SkDrawIter iter(this, false/*clear can affect empty clips*/); + SkDrawIter iter(this); this->predrawNotify(); while (iter.next()) { iter.fDevice->clear(color);