commit 91164d1c0118f39fd72d84c900fc28b0abeb1720
author Ethan Nicholas <ethannicholas@google.com> Wed May 15 15:29:54 2019 -0400
committer Skia Commit-Bot <skia-commit-bot@chromium.org> Wed May 15 20:05:45 2019 +0000
tree 2e1af05fb3b482146a6b1b0ea2b42e3a7e568785
parent fc1dddbb8d2610882589fca969c005bf3e99a645

added external value support to SkSL interpreter

Bug: skia:
Change-Id: I1806e1f6abaef322ecd3ba0d9bfaa9d7ca7a44c1
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/212983
Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>

src/sksl/SkSLCompiler.cpp

diff --git a/src/sksl/SkSLCompiler.cpp b/src/sksl/SkSLCompiler.cpp
index e7ff7e4..45065bc 100644
--- a/src/sksl/SkSLCompiler.cpp
+++ b/src/sksl/SkSLCompiler.cpp
@@ -296,6 +296,8 @@
                                 (std::unique_ptr<Expression>*) &fContext->fDefined_Expression,
                                 definitions);
             break;
+        case Expression::kExternalValue_Kind:
+            break;
         default:
             // not an lvalue, can't happen
             SkASSERT(false);
@@ -464,6 +466,8 @@
             const TernaryExpression& t = (TernaryExpression&) lvalue;
             return !t.fTest->hasSideEffects() && is_dead(*t.fIfTrue) && is_dead(*t.fIfFalse);
         }
+        case Expression::kExternalValue_Kind:
+            return false;
         default:
             ABORT("invalid lvalue: %s\n", lvalue.description().c_str());
     }
@@ -1232,6 +1236,14 @@
     }
 }
 
+void Compiler::registerExternalValue(ExternalValue* value) {
+    fIRGenerator->fRootSymbolTable->addWithoutOwnership(value->fName, value);
+}
+
+Symbol* Compiler::takeOwnership(std::unique_ptr<Symbol> symbol) {
+    return fIRGenerator->fRootSymbolTable->takeOwnership(std::move(symbol));
+}
+
 std::unique_ptr<Program> Compiler::convertProgram(Program::Kind kind, String text,
                                                   const Program::Settings& settings) {
     fErrorText = "";