commit 93ba0a4fc85f04bc1be9429983df1e57473b49a7
author Brian Osman <brianosman@google.com> Mon Aug 14 14:48:10 2017 -0400
committer Skia Commit-Bot <skia-commit-bot@chromium.org> Mon Aug 14 21:24:55 2017 +0000
tree 29b75949fdb9d449b28c000ff5f1e18eec19c42f
parent ba8275148ab8b10393b053e2586b852796c4afc2

Switch SkSL to std::string

On desktop, this saves just over 5% of the time in the SkSL compiler.

As written, the code will now build either way, so it's much easier to
switch back (or even have some platforms use SkString, if that's ever
required).

Bug: skia:
Change-Id: I634f26a4f6fcb404e59bda6a5c6a21a9c6d73c0b
Reviewed-on: https://skia-review.googlesource.com/34381
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>

src/gpu/vk/GrVkUtil.cpp

diff --git a/src/gpu/vk/GrVkUtil.cpp b/src/gpu/vk/GrVkUtil.cpp
index 84406c8..2ca701f 100644
--- a/src/gpu/vk/GrVkUtil.cpp
+++ b/src/gpu/vk/GrVkUtil.cpp
@@ -258,7 +258,7 @@
                              SkSL::Program::Inputs* outInputs) {
     std::unique_ptr<SkSL::Program> program = gpu->shaderCompiler()->convertProgram(
                                                               vk_shader_stage_to_skiasl_kind(stage),
-                                                              SkString(shaderString),
+                                                              SkSL::String(shaderString),
                                                               settings);
     if (!program) {
         SkDebugf("SkSL error:\n%s\n", gpu->shaderCompiler()->errorText().c_str());