| commit | 94c66475560de551a499334818df85966db7681c | [log] [tgz] |
|---|---|---|
| author | Khushal Sagar <khushalsagar@chromium.org> | Tue Sep 03 00:30:28 2019 +0000 |
| committer | Skia Commit-Bot <skia-commit-bot@chromium.org> | Tue Sep 03 00:55:44 2019 +0000 |
| tree | 15027b1f2f62d28bd536c10e9b6801f314d1c237 | |
| parent | 8203a180ea5dd9b1989e2f99863330fa2df0ce72 [diff] |
Revert "Only send the RemoteStrikes that have pending glyphs." This reverts commit 3783375c4d418e8fc4ccdc7d1b185f8407fc7824. Reason for revert: Glyph cache miss issues are back with this change (landed in 78.0.3898.0) : https://crash.corp.google.com/browse?q=product_name%3D%22Chrome%22+AND+expanded_custom_data.ChromeCrashProto.channel+IN+%28%22canary%22%29+AND+expanded_custom_data.ChromeCrashProto.magic_signature_1.name%3D%22%5BDump+without+crash%5D+SkScalerContextProxy%3A%3AgenerateMetrics%22 Original change's description: > Only send the RemoteStrikes that have pending glyphs. > > Count the number of strikes in fRemoteStrikesToSend that have > glyphs to send. The strike may not have glyphs to send, because they > were sent previously. Then, send the strikes that have glyphs to send. > Keep the bool in the serialization which indicates that strike > has glyphs and should always be true now. The bool will be removed in the next CL. > > Change-Id: I8b75d1bda574fd71adfd21cb20ff912340fc2e33 > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/237815 > Commit-Queue: Herb Derby <herb@google.com> > Reviewed-by: Khushal Sagar <khushalsagar@chromium.org> TBR=herb@google.com,khushalsagar@chromium.org,khushalsagar@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: I910734d9db570784b73e108d7b5abedd2efc5ad7 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/238778 Reviewed-by: Khushal Sagar <khushalsagar@chromium.org> Commit-Queue: Khushal Sagar <khushalsagar@chromium.org>