commit 96271cd1805d55b1a985652eebd0399ebe415283
author Brian Salomon <bsalomon@google.com> Mon Jul 31 16:27:23 2017 -0400
committer Skia Commit-Bot <skia-commit-bot@chromium.org> Mon Jul 31 20:51:42 2017 +0000
tree 951bef0f222b0eb3c087901cd810f805593e5965
parent f3ce7e3c673fd4ace2ca56effe4cfd2908919b9d

Require clone() be implemented by GrFragmentProcessor subclasses

Change-Id: I66ba0978e5748806d563ff4f26000e4e0095ed24
Reviewed-on: https://skia-review.googlesource.com/29042
Reviewed-by: Ethan Nicholas <ethannicholas@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>

src/gpu/effects/GrYUVEffect.cpp

diff --git a/src/gpu/effects/GrYUVEffect.cpp b/src/gpu/effects/GrYUVEffect.cpp
index 93f268a..5b2eb7e 100644
--- a/src/gpu/effects/GrYUVEffect.cpp
+++ b/src/gpu/effects/GrYUVEffect.cpp
@@ -250,11 +250,7 @@
     const char* name() const override { return "RGBToYUV"; }
 
     sk_sp<GrFragmentProcessor> clone() const override {
-        auto child = this->childProcessor(0).clone();
-        if (!child) {
-            return nullptr;
-        }
-        return Make(std::move(child), fColorSpace, fOutputChannels);
+        return Make(this->childProcessor(0).clone(), fColorSpace, fOutputChannels);
     }
 
     SkYUVColorSpace getColorSpace() const { return fColorSpace; }