commit 96dbf7403e4bc07d5bbab067661e735083c51768
author Ethan Nicholas <ethannicholas@google.com> Fri Sep 10 15:59:11 2021 -0400
committer SkCQ <skcq-be@skia-corp.google.com.iam.gserviceaccount.com> Fri Sep 10 20:44:22 2021 +0000
tree a185ea1219aff30ca38b8a311a0cb1b5d5b97f97
parent 181bb97c38537c190acc19362be00f0ff9423493

Reduced the number of temporary arrays created by DSLParser

Change-Id: I9b758fd816278b50d2b1182cbfe6e0752b09cc51
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/447720
Reviewed-by: John Stiles <johnstiles@google.com>
Commit-Queue: Ethan Nicholas <ethannicholas@google.com>

src/sksl/SkSLDSLParser.cpp

diff --git a/src/sksl/SkSLDSLParser.cpp b/src/sksl/SkSLDSLParser.cpp
index 525afc8..0678f8d 100644
--- a/src/sksl/SkSLDSLParser.cpp
+++ b/src/sksl/SkSLDSLParser.cpp
@@ -1169,7 +1169,7 @@
         return skstd::nullopt;
     }
     AutoDSLSymbolTable symbols;
-    SkTArray<DSLStatement> statements;
+    StatementArray statements;
     for (;;) {
         switch (this->peek().fKind) {
             case Token::Kind::TK_RBRACE:
@@ -1183,7 +1183,7 @@
                 if (!statement) {
                     return skstd::nullopt;
                 }
-                statements.push_back(std::move(*statement));
+                statements.push_back(statement->release());
             }
         }
     }