Make invokeChild just return a string containing the child function call

Also removes several unused chunks of code that were declaring unused
variables, etc.

Change-Id: I47458736b189d59c0448c6f58b60a9b4ab046db2
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/266565
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
diff --git a/src/gpu/effects/GrTextureDomain.cpp b/src/gpu/effects/GrTextureDomain.cpp
index cd15573..bb89148 100644
--- a/src/gpu/effects/GrTextureDomain.cpp
+++ b/src/gpu/effects/GrTextureDomain.cpp
@@ -93,9 +93,7 @@
                                                 GrGLSLFragmentProcessor::EmitArgs& args,
                                                 int childIndex) {
     auto appendProcessorSample = [parent, &args, childIndex, inColor](const char* coord) {
-        SkString outColor("childColor");
-        parent->invokeChild(childIndex, inColor, &outColor, args, coord);
-        return outColor;
+        return parent->invokeChild(childIndex, inColor, args, coord);
     };
     this->sample(args.fFragBuilder, args.fUniformHandler, textureDomain, outColor, inCoords,
                  appendProcessorSample);