commit 978693cdaa5fa58934747eb3142b76e3d515f44a
author Brian Osman <brianosman@google.com> Fri Jan 24 14:52:10 2020 -0500
committer Skia Commit-Bot <skia-commit-bot@chromium.org> Fri Jan 24 20:23:33 2020 +0000
tree 0a399808358dbeb0d90d495809820c1af5f842cd
parent 44aa1ab584e481089a4eb4fcaab6726cc52f250a

Make invokeChild just return a string containing the child function call

Also removes several unused chunks of code that were declaring unused
variables, etc.

Change-Id: I47458736b189d59c0448c6f58b60a9b4ab046db2
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/266565
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>

src/gpu/gradients/generated/GrTiledGradientEffect.cpp

diff --git a/src/gpu/gradients/generated/GrTiledGradientEffect.cpp b/src/gpu/gradients/generated/GrTiledGradientEffect.cpp
index 9d0637f..c544160 100644
--- a/src/gpu/gradients/generated/GrTiledGradientEffect.cpp
+++ b/src/gpu/gradients/generated/GrTiledGradientEffect.cpp
@@ -29,8 +29,8 @@
         (void)makePremul;
         auto colorsAreOpaque = _outer.colorsAreOpaque;
         (void)colorsAreOpaque;
-        SkString _sample453("_sample453");
-        this->invokeChild(_outer.gradLayout_index, &_sample453, args);
+        SkString _sample453;
+        _sample453 = this->invokeChild(_outer.gradLayout_index, args);
         fragBuilder->codeAppendf(
                 "half4 t = %s;\nif (!%s && t.y < 0.0) {\n    %s = half4(0.0);\n} else {\n    @if "
                 "(%s) {\n        half t_1 = t.x - 1.0;\n        half tiled_t = (t_1 - 2.0 * "
@@ -42,8 +42,8 @@
                                                                                        : "false"),
                 args.fOutputColor, (_outer.mirror ? "true" : "false"));
         SkString _input1464("t");
-        SkString _sample1464("_sample1464");
-        this->invokeChild(_outer.colorizer_index, _input1464.c_str(), &_sample1464, args);
+        SkString _sample1464;
+        _sample1464 = this->invokeChild(_outer.colorizer_index, _input1464.c_str(), args);
         fragBuilder->codeAppendf("\n    %s = %s;\n}\n@if (%s) {\n    %s.xyz *= %s.w;\n}\n",
                                  args.fOutputColor, _sample1464.c_str(),
                                  (_outer.makePremul ? "true" : "false"), args.fOutputColor,