commit 97df5dcb37c36d1dfa9d955166ad6e97e60cb3a3
author Florin Malita <fmalita@chromium.org> Mon Sep 10 15:53:27 2018 -0400
committer Skia Commit-Bot <skia-commit-bot@chromium.org> Tue Sep 11 21:14:25 2018 +0000
tree fd95c684aef717504ac874d8fbaa6e2d9a9d4b76
parent ea308103482b63f93110ba20e214d75e37bd9f15

[sksg] Stop caching full SkPaints in Paint nodes

Create on the fly, when needed.

TBR=
Bug: skia:8340
Change-Id: I4c319821a6d6e84e0ec37e8858c4a89ba1668626
Reviewed-on: https://skia-review.googlesource.com/153141
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Florin Malita <fmalita@chromium.org>

modules/sksg/include/SkSGPaintNode.h

diff --git a/modules/sksg/include/SkSGPaintNode.h b/modules/sksg/include/SkSGPaintNode.h
index 5c9563b..dc4af49 100644
--- a/modules/sksg/include/SkSGPaintNode.h
+++ b/modules/sksg/include/SkSGPaintNode.h
@@ -22,7 +22,7 @@
  */
 class PaintNode : public Node {
 public:
-    const SkPaint& makePaint();
+    SkPaint makePaint() const;
 
     SG_ATTRIBUTE(AntiAlias  , bool          , fAntiAlias  )
     SG_ATTRIBUTE(Opacity    , SkScalar      , fOpacity    )
@@ -41,8 +41,6 @@
     SkRect onRevalidate(InvalidationController*, const SkMatrix&) final;
 
 private:
-    SkPaint        fPaint;
-
     SkScalar       fOpacity     = 1,
                    fStrokeWidth = 1,
                    fStrokeMiter = 4;