| commit | 988adddd48322bfa3e3cb0c017cfce71fbbf1123 | [log] [tgz] |
|---|---|---|
| author | mtklein <mtklein@chromium.org> | Wed Nov 18 09:56:28 2015 -0800 |
| committer | Commit bot <commit-bot@chromium.org> | Wed Nov 18 09:56:28 2015 -0800 |
| tree | 30faaa91cb80045309c815e5a06ca6e2fa630d34 | |
| parent | 835c1b69a2b4238b63ad2daf0698c4fbb5fc944f [diff] |
Fix UB in SkDivBits DIVBITS_ITER was shifting bits up into the sign bit, which is a no-no. This turns numer into a uint32_t to make those defined, and adds a few notes. x >= 0 is always true for unsigned x, so we needed a few small logic refactors. BUG=skia:3562 Review URL: https://codereview.chromium.org/1455163004