commit 99e3f7d6fcb7b3b4340286455733a7de9eb4ef81
author Matt Sarett <msarett@google.com> Fri Oct 28 12:51:08 2016 -0400
committer Skia Commit-Bot <skia-commit-bot@chromium.org> Fri Oct 28 19:51:11 2016 +0000
tree afa0f4135c5e6dbc456ea3426c70524a4d50b92f
parent 8c05b450d2df755ecde183017e61c19a7a65725b

Remove unneeded SkColorSpace constructor
TBR=reed@google.com
BUG=skia:

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4140

Change-Id: Ib1c477b6b56a100ea449ffa20bdf18041c044a78
Reviewed-on: https://skia-review.googlesource.com/4140
Reviewed-by: Matt Sarett <msarett@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Matt Sarett <msarett@google.com>

tests/ColorSpaceTest.cpp

diff --git a/tests/ColorSpaceTest.cpp b/tests/ColorSpaceTest.cpp
index 76cb36d..7d86ae6 100644
--- a/tests/ColorSpaceTest.cpp
+++ b/tests/ColorSpaceTest.cpp
@@ -237,10 +237,6 @@
     monitorData = SkData::MakeFromFileName(GetResourcePath("icc_profiles/upperRight.icc").c_str());
     test_serialize(r, SkColorSpace::MakeICC(monitorData->data(), monitorData->size()).get(), false);
 
-    const float gammas[] = { 1.1f, 1.2f, 1.7f, };
-    SkMatrix44 toXYZ(SkMatrix44::kIdentity_Constructor);
-    test_serialize(r, SkColorSpace::MakeRGB(gammas, toXYZ).get(), false);
-
     SkColorSpaceTransferFn fn;
     fn.fA = 1.0f;
     fn.fB = 0.0f;
@@ -249,6 +245,7 @@
     fn.fE = 1.0f;
     fn.fF = 0.0f;
     fn.fG = 1.0f;
+    SkMatrix44 toXYZ(SkMatrix44::kIdentity_Constructor);
     test_serialize(r, SkColorSpace::MakeRGB(fn, toXYZ).get(), false);
 }
 
@@ -264,12 +261,6 @@
     sk_sp<SkColorSpace> upperLeft = SkColorSpace::MakeICC(data->data(), data->size());
     data = SkData::MakeFromFileName(GetResourcePath("icc_profiles/upperRight.icc").c_str());
     sk_sp<SkColorSpace> upperRight = SkColorSpace::MakeICC(data->data(), data->size());
-    const float gammas1[] = { 1.1f, 1.2f, 1.3f, };
-    const float gammas2[] = { 1.1f, 1.2f, 1.7f, };
-    SkMatrix44 toXYZ(SkMatrix44::kIdentity_Constructor);
-    sk_sp<SkColorSpace> rgb1 = SkColorSpace::MakeRGB(gammas1, toXYZ);
-    sk_sp<SkColorSpace> rgb2 = SkColorSpace::MakeRGB(gammas2, toXYZ);
-    sk_sp<SkColorSpace> rgb3 = SkColorSpace::MakeRGB(gammas1, toXYZ);
 
     SkColorSpaceTransferFn fn;
     fn.fA = 1.0f;
@@ -279,6 +270,7 @@
     fn.fE = 1.0f;
     fn.fF = 0.0f;
     fn.fG = 1.0f;
+    SkMatrix44 toXYZ(SkMatrix44::kIdentity_Constructor);
     sk_sp<SkColorSpace> rgb4 = SkColorSpace::MakeRGB(fn, toXYZ);
 
     REPORTER_ASSERT(r, SkColorSpace::Equals(nullptr, nullptr));
@@ -288,8 +280,6 @@
     REPORTER_ASSERT(r, SkColorSpace::Equals(z32.get(), z32.get()));
     REPORTER_ASSERT(r, SkColorSpace::Equals(upperLeft.get(), upperLeft.get()));
     REPORTER_ASSERT(r, SkColorSpace::Equals(upperRight.get(), upperRight.get()));
-    REPORTER_ASSERT(r, SkColorSpace::Equals(rgb1.get(), rgb1.get()));
-    REPORTER_ASSERT(r, SkColorSpace::Equals(rgb1.get(), rgb3.get()));
     REPORTER_ASSERT(r, SkColorSpace::Equals(rgb4.get(), rgb4.get()));
 
     REPORTER_ASSERT(r, !SkColorSpace::Equals(nullptr, srgb.get()));
@@ -301,8 +291,8 @@
     REPORTER_ASSERT(r, !SkColorSpace::Equals(upperLeft.get(), upperRight.get()));
     REPORTER_ASSERT(r, !SkColorSpace::Equals(z30.get(), upperRight.get()));
     REPORTER_ASSERT(r, !SkColorSpace::Equals(upperRight.get(), adobe.get()));
-    REPORTER_ASSERT(r, !SkColorSpace::Equals(rgb1.get(), rgb2.get()));
-    REPORTER_ASSERT(r, !SkColorSpace::Equals(rgb1.get(), rgb4.get()));
+    REPORTER_ASSERT(r, !SkColorSpace::Equals(z30.get(), rgb4.get()));
+    REPORTER_ASSERT(r, !SkColorSpace::Equals(srgb.get(), rgb4.get()));
 }
 
 static inline bool matrix_almost_equal(const SkMatrix44& a, const SkMatrix44& b) {