commit 9b8b4558d2f75038ca7bdf31139ddf6e77c45272
author Brian Osman <brianosman@google.com> Mon Sep 30 13:23:14 2019 -0400
committer Skia Commit-Bot <skia-commit-bot@chromium.org> Mon Sep 30 18:02:24 2019 +0000
tree a760cf0010c953871973ba21ca91c112ea5dc11d
parent 04b9964167358e716a44f90cc70f738134128622

Change ByteCode and ByteCodeFunction to classes

The lack of encapsulation was finally starting to bother me. Had to
change the Interpreter namespace to a struct so that it could be
friended, but otherwise this was a nice and simple cleanup.

Also updated the comments on the two run functions, and renamed
fInputSlots to fUniformSlots, to reflect recent clarification
around in vs. uniform.

Change-Id: I24bbc59778b3ab6448bffcf98133d5c149a060a9
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/244883
Reviewed-by: Ethan Nicholas <ethannicholas@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>

src/sksl/SkSLByteCodeGenerator.cpp

diff --git a/src/sksl/SkSLByteCodeGenerator.cpp b/src/sksl/SkSLByteCodeGenerator.cpp
index e07a22e..acfbac5 100644
--- a/src/sksl/SkSLByteCodeGenerator.cpp
+++ b/src/sksl/SkSLByteCodeGenerator.cpp
@@ -73,7 +73,7 @@
 //                    SkASSERT(!(declVar->fModifiers.fFlags & Modifiers::kIn_Flag));
                     if (declVar->fModifiers.fFlags & Modifiers::kUniform_Flag) {
                         for (int i = SlotCount(declVar->fType); i > 0; --i) {
-                            fOutput->fInputSlots.push_back(fOutput->fGlobalCount++);
+                            fOutput->fUniformSlots.push_back(fOutput->fGlobalCount++);
                         }
                     } else {
                         fOutput->fGlobalCount += SlotCount(declVar->fType);