commit 9ce80f71de026a1e1f9875ee5da55742e4fd3b53
author John Stiles <johnstiles@google.com> Thu Mar 11 22:35:19 2021 -0500
committer Skia Commit-Bot <skia-commit-bot@chromium.org> Fri Mar 12 14:18:06 2021 +0000
tree af5388e6f8b7cbb20d8bf3d6e65d42168918f18e
parent 91113acfd1d607e4218a13f3c9152f7547cef900

Add Make factory functions to literal types.

This is mostly for consistency with other IRNode types; there isn't any
optimization opportunity or error checking for literals.

Change-Id: I0e6a55cddbd814585ecafeddab4e591fe5113911
Bug: skia:11342
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/383996
Auto-Submit: John Stiles <johnstiles@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>

src/sksl/SkSLRehydrator.cpp

diff --git a/src/sksl/SkSLRehydrator.cpp b/src/sksl/SkSLRehydrator.cpp
index 9f15deb..ce02ed3 100644
--- a/src/sksl/SkSLRehydrator.cpp
+++ b/src/sksl/SkSLRehydrator.cpp
@@ -288,7 +288,7 @@
                 int value = this->readS32();
                 // enum variables aren't really 'declared', but we have to create a declaration to
                 // store the value
-                auto valueLiteral = std::make_unique<IntLiteral>(fContext, /*offset=*/-1, value);
+                auto valueLiteral = IntLiteral::Make(fContext, /*offset=*/-1, value);
                 auto declaration = std::make_unique<VarDeclaration>(&v, &v.type(), /*arraySize=*/0,
                                                                     std::move(valueLiteral));
                 v.setDeclaration(declaration.get());
@@ -446,7 +446,7 @@
         }
         case Rehydrator::kBoolLiteral_Command: {
             bool value = this->readU8();
-            return std::make_unique<BoolLiteral>(fContext, -1, value);
+            return BoolLiteral::Make(fContext, /*offset=*/-1, value);
         }
         case Rehydrator::kConstructor_Command: {
             const Type* type = this->type();
@@ -470,7 +470,7 @@
             const Type* type = this->type();
             FloatIntUnion u;
             u.fInt = this->readS32();
-            return std::make_unique<FloatLiteral>(-1, u.fFloat, type);
+            return FloatLiteral::Make(/*offset=*/-1, u.fFloat, type);
         }
         case Rehydrator::kFunctionCall_Command: {
             const Type* type = this->type();
@@ -492,7 +492,7 @@
         case Rehydrator::kIntLiteral_Command: {
             const Type* type = this->type();
             int value = this->readS32();
-            return std::make_unique<IntLiteral>(-1, value, type);
+            return IntLiteral::Make(/*offset=*/-1, value, type);
         }
         case Rehydrator::kPostfix_Command: {
             Token::Kind op = (Token::Kind) this->readU8();