commit 9de4dc9b1ecb724757a9895c6a7d32d6267bf211
author reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> Fri Jul 15 14:14:45 2011 +0000
committer reed@google.com <reed@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> Fri Jul 15 14:14:45 2011 +0000
tree 44ac4452e448c5e18a0622f8a57be4c3ec34ddf5
parent 6c841008c46db5a23b386f765f7883ed6d125a8a

check for non-finite values that can make us overshoot



git-svn-id: http://skia.googlecode.com/svn/trunk@1870 2bbb7eff-a529-9590-31e7-b0007b416f81

src/effects/SkDashPathEffect.cpp

diff --git a/src/effects/SkDashPathEffect.cpp b/src/effects/SkDashPathEffect.cpp
index b1f58e6..f593b57 100644
--- a/src/effects/SkDashPathEffect.cpp
+++ b/src/effects/SkDashPathEffect.cpp
@@ -62,12 +62,18 @@
             phase = SkScalarMod(phase, len);
         }
 
+        // got to watch out for values that might make us go out of bounds
+        if (!SkScalarIsFinite(phase) || !SkScalarIsFinite(len)) {
+            goto BAD_DASH;
+        }
+
         SkASSERT(phase >= 0 && phase < len);
         fInitialDashLength = FindFirstInterval(intervals, phase, &fInitialDashIndex);
 
         SkASSERT(fInitialDashLength >= 0);
         SkASSERT(fInitialDashIndex >= 0 && fInitialDashIndex < fCount);
     } else {
+        BAD_DASH:
         fInitialDashLength = -1;    // signal bad dash intervals
     }
 }