Allow --disableDriverCorrectnessWorkarounds to enable MSAA on Intel GPUs
Historically we have seen stability issues with MSAA on older Intel
GPUs, and some performance problems as well. However, this can still be
valuable for debugging the MSAA rendering path on machines that lack a
discrete GPU, e.g. a laptop or small form-factor PC.
Bug: chromium:527565, chromium:983926
Change-Id: Ic18a878e3b57a4a136a1c008371593da8aa186e8
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/290830
Auto-Submit: John Stiles <johnstiles@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
diff --git a/src/gpu/gl/GrGLCaps.cpp b/src/gpu/gl/GrGLCaps.cpp
index dacb466..4d6e836 100644
--- a/src/gpu/gl/GrGLCaps.cpp
+++ b/src/gpu/gl/GrGLCaps.cpp
@@ -1041,13 +1041,6 @@
fMSFBOType = kNone_MSFBOType;
}
}
-
- // We disable MSAA for all Intel GPUs. Before Gen9, performance was very bad. Even with Gen9,
- // we've seen driver crashes in the wild. We don't have data on Gen11 yet.
- // chromium:527565, chromium:983926
- if (kIntel_GrGLVendor == ctxInfo.vendor()) {
- fMSFBOType = kNone_MSFBOType;
- }
}
void GrGLCaps::initBlendEqationSupport(const GrGLContextInfo& ctxInfo) {
@@ -3999,6 +3992,13 @@
if (ctxInfo.angleBackend() == GrGLANGLEBackend::kD3D9) {
formatWorkarounds->fDisallowBGRA8ReadPixels = true;
}
+
+ // We disable MSAA for all Intel GPUs. Before Gen9, performance was very bad. Even with Gen9,
+ // we've seen driver crashes in the wild. We don't have data on Gen11 yet.
+ // (crbug.com/527565, crbug.com/983926)
+ if (kIntel_GrGLVendor == ctxInfo.vendor()) {
+ fMSFBOType = kNone_MSFBOType;
+ }
}
void GrGLCaps::onApplyOptionsOverrides(const GrContextOptions& options) {