f16<->f32 ftz is an optional thing for speed.
The ARMv8 asm path actually does it right... that should be okay.
My Nexus 5x fails `dm -m _finite_ftz` before this and passes after it.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2276533002
TBR=msarett@google.com
Review-Url: https://codereview.chromium.org/2276533002
diff --git a/tests/Float16Test.cpp b/tests/Float16Test.cpp
index 3e05758..9983568 100644
--- a/tests/Float16Test.cpp
+++ b/tests/Float16Test.cpp
@@ -70,10 +70,13 @@
continue;
}
- // _finite_ftz() flushes denorms to zero. 0.0f will compare == with both +0.0f and -0.0f.
- float expected = is_denorm(h) ? 0.0f : SkHalfToFloat(h);
+ // _finite_ftz() may flush denorms to zero. 0.0f will compare == with both +0.0f and -0.0f.
+ float expected = SkHalfToFloat(h),
+ alternate = is_denorm(h) ? 0.0f : expected;
- REPORTER_ASSERT(r, SkHalfToFloat_finite_ftz(h)[0] == expected);
+ float actual = SkHalfToFloat_finite_ftz(h)[0];
+
+ REPORTER_ASSERT(r, actual == expected || actual == alternate);
}
}
@@ -94,13 +97,15 @@
continue;
}
+ uint16_t alternate = expected;
if (is_denorm(expected)) {
- // _finite_ftz() flushes denorms to zero, and happens to keep the sign bit.
- expected = signbit(f) ? 0x8000 : 0x0000;
+ // _finite_ftz() may flush denorms to zero, and happens to keep the sign bit.
+ alternate = signbit(f) ? 0x8000 : 0x0000;
}
uint16_t actual = SkFloatToHalf_finite_ftz(Sk4f{f})[0];
- // _finite_ftz() truncates instead of rounding, so it may be one too small.
- REPORTER_ASSERT(r, actual == expected || actual == expected - 1);
+ // _finite_ftz() may truncate instead of rounding, so it may be one too small.
+ REPORTER_ASSERT(r, actual == expected || actual == expected - 1 ||
+ actual == alternate || actual == alternate - 1);
}
}